Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/paginator #94

Merged
merged 30 commits into from
Mar 31, 2017
Merged

Feature/paginator #94

merged 30 commits into from
Mar 31, 2017

Conversation

romaninsh
Copy link
Member

Merge #93 before (although - not a dependency)

This is implementation of Paginator component:

screen shot 2017-03-30 at 19 06 51

The component can work on it's own, it does not need to be attached anywhere. You can manually specify number of total pages to the paginator. The above output:

$layout->add(['Paginator', 'total'=>40]);

Multiple paginators will not affect each-other.

Paginator can reload other view which can synergise by pulling current page from paginator.

$seg = $layout->add(['View', 'ui'=>'blue segment']);
$label = $seg->add(['Label']);
$bb = $seg->add(['Paginator', 'total'=>50, 'range'=>2, 'reload'=>$seg]);
$label->addClass('blue ribbon');
$label->set('Current page: '.$bb->page);

screen shot 2017-03-30 at 19 11 03

@DarkSide666 DarkSide666 self-requested a review March 31, 2017 11:01
/**
* If specified, must be instance of a view which will be reloaded on selection.
*/
public $reload = null;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see this implemented

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in renderView() method.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, missed these lines :)

@DarkSide666 DarkSide666 merged commit dea8769 into develop Mar 31, 2017
@DarkSide666 DarkSide666 deleted the feature/paginator branch March 31, 2017 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants