Finally implementing Grid #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I must also add that this PR fixes HTML-escaping in Table. |
Merged
romaninsh
commented
Mar 31, 2017
| $this->setAttr('href', $this->app->url($url)); | ||
|
|
||
| return $this; | ||
| } | ||
| } |
|
Actually - docs will come in the final implementation of Grid, which I'm yet to PR. |
fixed this once few days ago, but it appeared again :)
DarkSide666
requested changes
Mar 31, 2017
|
|
||
| $output[] = $column->getCellTemplate($field); | ||
| // If multiple formatters are defined, use the first for the header cell |
There was a problem hiding this comment.
If data cell has multiple formatters, then all of them should be used here. This is not header cell here !
| */ | ||
| public function jsChecked() | ||
| { | ||
| return new \atk4\ui\jsExpression(' $('.$this->table->jsRender().").find('.checked.".$this->class."').closest('tr').map(function(){ ". |
There was a problem hiding this comment.
can't we use simpler JS syntax here? something like:
$(...).find('.checked.xxx').closest('tr').get(0).data('id');
There was a problem hiding this comment.
I'll refactor those later with JSLib. Will create a separate issue.
DarkSide666
approved these changes
Mar 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge #74 first.
This PR implements a new Grid class with a bunch of features: