Feature/form #29
Merged
Feature/form #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added form implementation:
(see demos/input.php) |
|
Added more field types: |
DarkSide666
approved these changes
Jan 6, 2017
| if ($this->rightIcon && !is_object($this->rightIcon)) { | ||
| $this->rightIcon = $this->add(new Icon($this->rightIcon), 'Content'); | ||
|
|
||
| if ($this->content) { |
There was a problem hiding this comment.
what is $this->icon or $this->rightIcon is already an object? Shouldn't we execute this part of code in such case too? (add class labeled, remove content etc.)
There was a problem hiding this comment.
that's currently incosistent in the project but i've addressed that in the next PR, but i'm not fully sure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(includes #28), on-going work for implementing Form. Because of how extensive the functionality of Form is, there might be multiple phases for Form implementation, i'll try to keep it structured though.
Further work is done in feature/form2 branch: