implement server-side on() events #28
Conversation
…ify template name.
|
I am OK with the remaining 4 code-climate issues. I don't want to disable them because we will need to address them at some point. |
|
|
||
| $buttons->on('click', '.button', $b3->js()->hide()); |
There was a problem hiding this comment.
There is major overhaul on js.rst in the next PR.
| @@ -478,7 +495,7 @@ public function getHTML() | |||
| * | |||
There was a problem hiding this comment.
no description what $extra parameter is for
There was a problem hiding this comment.
it's changed in the next PR, so leaving.
| return $r->jsRender(); | ||
| }, $actions)); | ||
|
|
||
| echo json_encode(['success'=>true, 'message'=>'Hello World', 'eval'=>$ajaxec]); |
There was a problem hiding this comment.
This is changed in the next PR, so i'll leave it to avoid conflicts.
| exit; | ||
| }); | ||
|
|
||
| $thisAction->api(['on'=>'now', 'url'=>$cb->getURL(), 'obj'=>new jsExpression('this')]); |
There was a problem hiding this comment.
$thisAction->api ? what is that?
There was a problem hiding this comment.
that's Semantic UI ;)
| * Provides replacement for json_encode that will respect jsExpressionable objects | ||
| * and call jsRender() for them instead of escaping. | ||
| * | ||
| * @param mixed @arg anything |
There was a problem hiding this comment.
should be $arg instead of @arg
| @@ -0,0 +1,19 @@ | |||
| <?php | |||
There was a problem hiding this comment.
what is this class for? where is it used?
There was a problem hiding this comment.
removing it, it's confusing.
This pull requests aims to make this code work:
Clicking a button here would execute request to the server that would generate the new label for a button.