Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade PHPStan to v1.11.1 #2205

Merged
merged 15 commits into from
May 15, 2024
Merged

Upgrade PHPStan to v1.11.1 #2205

merged 15 commits into from
May 15, 2024

Conversation

DarkSide666
Copy link
Member

@DarkSide666 DarkSide666 commented May 8, 2024 •
edited by mvorisek
Loading

fix #2201

@DarkSide666 DarkSide666 requested a review from mvorisek May 8, 2024 09:44
@mvorisek mvorisek marked this pull request as draft May 9, 2024 04:33
@mvorisek
Copy link
Member

mvorisek commented May 9, 2024 •
edited
Loading

I am waiting on a new phpstan release because of phpstan/phpstan-strict-rules@8afd4af and phpstan/phpstan#10893

@mvorisek mvorisek removed their request for review May 9, 2024 04:42
@DarkSide666
Copy link
Member Author

OK great.
But this one probably should be made as separate PR here?
https://github.com/atk4/ui/pull/2205/files#diff-6f19df6a6307a48db0940e6897591fb08776d2db8a6134737aa708defdb5c92dR402

@mvorisek
Copy link
Member

mvorisek commented May 9, 2024 •
edited
Loading

We can, but we should not land the src/Persistence/Ui.php changes like proposed here, we can baseline then, but I prefer to wait for the next phpstan release...

@mvorisek mvorisek changed the title Fix phpstan errors Fix phpstan v1.10.68 May 12, 2024
@mvorisek mvorisek force-pushed the feature/fix-phpstan-errors branch from 9c5b94e to a69c18e Compare May 14, 2024 07:05
@mvorisek mvorisek force-pushed the feature/fix-phpstan-errors branch from 182ad02 to 63df8b5 Compare May 15, 2024 11:12
@mvorisek mvorisek changed the title Fix phpstan v1.10.68 Upgrade PHPStan to v1.11.1 May 15, 2024
@mvorisek mvorisek force-pushed the feature/fix-phpstan-errors branch from c0e2ab6 to fa7b3b6 Compare May 15, 2024 15:53
@mvorisek mvorisek marked this pull request as ready for review May 15, 2024 16:01
@mvorisek mvorisek merged commit fb52f9c into develop May 15, 2024
48 checks passed
@mvorisek mvorisek deleted the feature/fix-phpstan-errors branch May 15, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tutorial intro.php is broken
2 participants
@DarkSide666 @mvorisek