Fix UploadImage::clearThumbnail default image reset

demos/form-control/upload.php

@@ -21,7 +21,7 @@
 // $control->set('a_generated_token');
 
 $img->onDelete(function (string $fileId) use ($img) {
-    $img->clearThumbnail('./images/default.png');
+    $img->clearThumbnail();
 
     return new JsToast([
         'title' => 'Delete successfully',

docs/fileupload.rst

@@ -140,7 +140,7 @@ UploadImage form control inherits all of the Upload properties plus these ones:
 
 The thumbnail view associated with the form control.
 
-.. php:attr:: thumnailRegion
+.. php:attr:: thumbnailRegion
 
 The region in input template where to add the thumbnail view, default to AfterAfterInput region.
 

src/Behat/Context.php

@@ -809,6 +809,18 @@ public function textInContainerShouldMatchRegex(string $selector, string $regex)
         }
     }
 
+    /**
+     * @Then Element :arg1 attribute :arg2 should contain text :arg3
+     */
+    public function elementAttributeShouldContainText(string $selector, string $attribute, string $text): void
+    {
+        $element = $this->findElement(null, $selector);
+        $attr = $element->getAttribute($attribute);
+        if (!str_contains($attr, $text)) {
+            throw new \Exception('Element " . $selector . " attribute "' . $attribute . '" does not contain "' . $text . '"');
+        }
+    }
+
     // }}}
 
     /**

src/Form/Control/UploadImage.php

@@ -17,9 +17,9 @@ class UploadImage extends Upload
      *
      * @var string
      */
-    public $thumnailRegion = 'AfterAfterInput';
+    public $thumbnailRegion = 'AfterAfterInput';
 
-    /** @var string The default thumbnail source. */
+    /** @var string|null The default thumbnail source. */
     public $defaultSrc;
 
     protected function init(): void
@@ -30,24 +30,27 @@ protected function init(): void
             $this->accept = ['.jpg', '.jpeg', '.png'];
         }
 
-        if (!$this->thumbnail) {
+        $this->add($this->getThumbnail(), $this->thumbnailRegion);
+    }
+
+    public function getThumbnail(): View
+    {
+        if ($this->thumbnail === null) {
             $this->thumbnail = (new View(['element' => 'img', 'class' => ['right', 'floated', 'image'], 'ui' => true]))
                 ->setAttr(['width' => 36, 'height' => 36]);
-        }
 
-        if ($this->defaultSrc) {
-            $this->thumbnail->setAttr(['src' => $this->defaultSrc]);
+            if ($this->defaultSrc) {
+                $this->thumbnail->setAttr(['src' => $this->defaultSrc]);
+            }
         }
 
-        $this->add($this->thumbnail, $this->thumnailRegion);
+        return $this->thumbnail;
     }
 
     /**
      * Set the thumbnail img src value.
-     *
-     * @param string $src
      */
-    public function setThumbnailSrc($src): void
+    public function setThumbnailSrc(string $src): void
     {
         $this->thumbnail->setAttr(['src' => $src]);
         $action = $this->thumbnail->js();
@@ -57,15 +60,12 @@ public function setThumbnailSrc($src): void
 
     /**
      * Clear the thumbnail src.
-     * You can also supply a default thumbnail src.
-     *
-     * @param string $defaultThumbnail
      */
-    public function clearThumbnail($defaultThumbnail = null): void
+    public function clearThumbnail(): void
     {
         $action = $this->thumbnail->js();
-        if ($defaultThumbnail !== null) {
-            $action->attr('src', $defaultThumbnail);
+        if ($this->defaultSrc !== null) {
+            $action->attr('src', $this->defaultSrc);
         } else {
             $action->removeAttr('src');
         }

tests-behat/upload.feature

@@ -7,3 +7,13 @@ Feature: Upload
 
     When I select file input "file" with "Žlutý kůň" as "$kůň"
     Then Toast display should contain text "(name: $kůň, md5: b047fb155be776f5bbae061c7b08cdf0)"
+
+    When I click using selector "xpath(//div.action[.//input[@name='file']]//div.button)"
+    Then Toast display should contain text "has been removed"
+
+    When I select file input "img" with "Foo" as "bar.png"
+    Then Toast display should contain text "is uploaded"
+
+    When I click using selector "xpath(//div.action[.//input[@name='img']]//div.button)"
+    Then Toast display should contain text "has been removed"
+    Then Element "xpath(//div.action[.//div//input[@name='img']]//img)" attribute "src" should contain text "default.png"