Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UploadImage::clearThumbnail default image reset #2027

Merged
merged 23 commits into from
Apr 4, 2023
Merged

Fix UploadImage::clearThumbnail default image reset #2027

merged 23 commits into from
Apr 4, 2023

Conversation

DarkSide666
Copy link
Member

@DarkSide666 DarkSide666 commented Mar 30, 2023 •
edited
Loading

defaultSrc property should also be used in clearThumbnail method if no thumbnail is passed as method argument.

@mvorisek
Copy link
Member

Am I right the defaultSrc is/was working, but not when/with clearThumbnail method only?

Also please name the PRs better, but still <70 chars, to be self explainatory in the changelog. No RTM label needed, if PR is not RTM, mark is as draft.

@DarkSide666 DarkSide666 removed the RTM label Mar 31, 2023
@DarkSide666 DarkSide666 changed the title Use defaultSrc too if it is set defaultSrc is not used in clearThumbnail method Mar 31, 2023
@DarkSide666 DarkSide666 requested a review from mvorisek March 31, 2023 09:40
@mvorisek mvorisek changed the title defaultSrc is not used in clearThumbnail method Fix UploadImage::clearThumbnail default image reset Mar 31, 2023
@DarkSide666 DarkSide666 requested a review from mvorisek April 3, 2023 12:22
@DarkSide666
Copy link
Member Author

DarkSide666 commented Apr 3, 2023 •
edited
Loading

Comments addressed.

CodeCov has slight delay, but now it shows correct +0.30%

@DarkSide666 DarkSide666 requested a review from mvorisek April 3, 2023 16:25
mvorisek
mvorisek reviewed Apr 3, 2023
View reviewed changes
tests-behat/upload.feature Outdated Show resolved Hide resolved
@DarkSide666 DarkSide666 requested a review from mvorisek April 3, 2023 17:13
@DarkSide666 DarkSide666 requested review from mvorisek and removed request for mvorisek April 3, 2023 20:09
@mvorisek mvorisek merged commit 316eca3 into develop Apr 4, 2023
@mvorisek mvorisek deleted the feature/use-set-default-thumbnail branch April 4, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvorisek mvorisek mvorisek left review comments

@georgehristov georgehristov Awaiting requested review from georgehristov

@mkrecek234 mkrecek234 Awaiting requested review from mkrecek234

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DarkSide666 @mvorisek