Improve exception renderers #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
force-pushed
the
ex_render_improve
branch
from
b5ec9cb to
907aa79
Compare
mvorisek
force-pushed
the
ex_render_improve
branch
from
b4f8fcd to
d413020
Compare
DarkSide666
reviewed
Feb 10, 2025
|
|
||
| private function optimizeText(string $value): string | ||
| { | ||
| $res = preg_replace("~\e\\[\\d{1,2}m\e\\[0m~", '', $value); |
There was a problem hiding this comment.
would be nice to add small comment here about what these regexes does
first removes empty sequences, but second ...
DarkSide666
reviewed
Feb 10, 2025
DarkSide666
reviewed
Feb 10, 2025
| @@ -268,14 +268,12 @@ protected function makeRelativePath(string $path): string | |||
|
|
|||
| protected function tryRelativizePathsInString(string $str): string | |||
| { | |||
| $str = preg_replace_callback('~(?<!\w)(?:[/\\\]|[a-z]:)\w?+[^:"\',;]*?\.php(?!\w)~i', function ($matches) { | |||
| return preg_replace_callback('~(?<!\w)(?:[/\\\]|[a-z]:)\w?+[^:"\',;]*?\.php(?!\w)~i', function ($matches) { | |||
There was a problem hiding this comment.
would be nice to add comment about what this regex does
There was a problem hiding this comment.
AFAIK, this is even untested (exact behaviour is unasserted), thus help welcomed. It is a little problematic as the repo can be part of another repo and the tests should still pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improve #421