Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix console exception renderer #421

Merged
merged 31 commits into from
Feb 8, 2025
Merged

Fix console exception renderer #421

merged 31 commits into from
Feb 8, 2025

Conversation

DarkSide666
Copy link
Member

@DarkSide666 DarkSide666 commented Feb 7, 2025 •
edited by mvorisek
Loading

fix #420

  • fix missing reset codes
  • add all colors as constants
  • use unified text styling method
  • replace PHP_EOL with \n because it works nicely in Windows console too
  • add additional tests

@DarkSide666 DarkSide666 requested a review from mvorisek February 7, 2025 23:39
mvorisek
mvorisek reviewed Feb 7, 2025
View reviewed changes
tests/ExceptionTest.php Outdated Show resolved Hide resolved
@mvorisek mvorisek changed the title Fix and improve ExceptionRenderer Fix console exception renderer Feb 8, 2025
@mvorisek mvorisek force-pushed the feature/fix-exception-renderer branch from 23c2da5 to 4073c41 Compare February 8, 2025 18:57
@mvorisek mvorisek merged commit 14132c2 into develop Feb 8, 2025
31 checks passed
@mvorisek mvorisek deleted the feature/fix-exception-renderer branch February 8, 2025 19:00
@mvorisek mvorisek mentioned this pull request Feb 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvorisek mvorisek mvorisek left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ExceptionRenderer/Console switch to yellow font
2 participants
@DarkSide666 @mvorisek