Support dub's actual (and special) dub test configuration
#173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Via e.g. `reggae --dub-config=unittest --dub-build-type=unittest`.
kinke
force-pushed
the
dub_unittest
branch
3 times, most recently
from
1c04888 to
d961c1c
Compare
Those using dub projects with a special test configuration. Mainly adapt to changed test runner filenames, and the automatic exclusion/replacement of mainSourceFile (and so all unittests in source/app.d etc. being excluded).
As there should now always be a `unittest` entry in `configToDubInfo` - except for some `targetType "none"` edge cases.
For better encapsulation.
kinke
added a commit
to symmetryinvestments/ldc
that referenced
this pull request
Jul 16, 2022
Using current dub master and supporting the actual `dub test` config, see atilaneves/reggae#173.
Unfortunately requiring a new workaround for an undefined symbol for the unittests.
atilaneves
reviewed
Jul 25, 2022
As with bootstrap.sh I'm hitting undefined symbol: _D3std8typecons__T5TupleTS3dub18dependencyresolver__T18DependencyResolverTSQBx10dependency10DependencyTQBdZQCc8TreeNodeTSQDrQDq__TQCzTQCiTQCmZQDl9TreeNodesZQFi__T5opCmpTxSQGnQGm__TQGgTQGdTQCqZQGsZQBiMxFxQBhZi with DMD v2.100.1 on Linux since the dub bump...
As bootstrapping fails with DMD v2.098.0 on Linux and Mac - *not* related to the -allinst removal, but to the dub bump, which is now using std.sumtype.
|
Still a bit cautious wrt. the dub bump, as dub v1.30.0 is a pretty big update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dub testadds a special test configuration if there's either nounittestconfig, or itstargetTypeisn'texecutable. That special config is derived from theunittest(or default) configuration, incl. generating and compiling-in an extradub_test_rootmodule with amain()entry point (and anAliasSeqof all root project modules). See dlang/dub#2218 for details. That PR landed after the dub v1.29 branch-off, so will land in v1.30. dlang/dub#2288 and dlang/dub#2300 are additionally required for reggae and will land in v1.30 too.