[minor cleanups]

atilaneves · Jul 14, 2022 · 77ad7e4 · 77ad7e4
1 parent b8f4985
commit 77ad7e4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/src/reggae/dub/interop/dublib.d b/src/reggae/dub/interop/dublib.d
@@ -85,7 +85,7 @@ struct Dub {
         // add the special `dub test` configuration (which doesn't require an existing `unittest` config)
         const testConfig = (allConfigs || singleConfig == "unittest")
             ? _project.addTestRunnerConfiguration(settings)
-            : null;
+            : null; // skip when requesting a single non-unittest config
         const haveSpecialTestConfig = testConfig.length && testConfig != "unittest";
 
         if (!allConfigs) {

diff --git a/src/reggae/dub/interop/package.d b/src/reggae/dub/interop/package.d
@@ -103,7 +103,7 @@ private from!"reggae.dub.info".DubInfo getDubInfo
 
         auto settings = dub.getGeneratorSettings(options);
         const configs = dubConfigurations(output, dub, options, settings);
-        const haveTestConfig = configs.test.length != 0;
+        const haveTestConfig = configs.test != "";
         bool atLeastOneConfigOk;
         Exception dubInfoFailure;
 
@@ -127,7 +127,7 @@ private from!"reggae.dub.info".DubInfo getDubInfo
         gDubInfos["default"] = gDubInfos[configs.default_];
 
         // (additionally) expose the special `dub test` config as `unittest` config in the DSL (`configToDubInfo`)
-        // (`dubTestTarget!()`, `dubConfigurationTarget!(Configuration("unittest"))` etc.)
+        // (for `dubTestTarget!()`, `dubConfigurationTarget!(Configuration("unittest"))` etc.)
         if(haveTestConfig && configs.test != "unittest" && configs.test in gDubInfos)
             gDubInfos["unittest"] = gDubInfos[configs.test];
     }
@@ -145,7 +145,6 @@ dubConfigurations
 {
     import reggae.dub.interop.configurations: DubConfigurations;
     import reggae.io: log;
-    import std.exception: enforce;
 
     const allConfigs = options.dubConfig == "";