Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: slack ID made optional. #1677

Merged
merged 5 commits into from
Feb 4, 2025
Merged

fix: slack ID made optional. #1677

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9e908fc
fix: made slack ID optional
neoandmatrix Feb 1, 2025
be0d44f
fix: minor fixes
neoandmatrix Feb 1, 2025
58589be
fix: slack fields made optional for groups and channels
neoandmatrix Feb 1, 2025
c495c96
Merge branch 'master' into slack-fix
neoandmatrix Feb 2, 2025
605e804
Merge branch 'master' into slack-fix
thulieblack Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/slack/channels/channels.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ locals {
purpose = lookup(lookup(lookup(wg_data, "slack", {}), "channel", {}), "description", lookup(wg_data, "description", ""))
topic = lookup(lookup(lookup(wg_data, "slack", {}), "channel", {}), "topic", "")

permanent_members = concat([for member in wg_data.chairpersons : member.slack], [for member in wg_data.members : member.slack])
permanent_members = concat([for member in wg_data.chairpersons : lookup(member, "slack", null)], [for member in wg_data.members : lookup(member, "slack", null)])
is_private = false

action_on_destroy = "archive"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/slack/groups/groups.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ locals {

# Handle will be the name of the group in lowercase and with spaces replaced by hyphens succeded by "wg-"
handle = lookup(lookup(lookup(wg_data, "slack", {}), "group", {}), "handle", "${replace(lower(wg_data.name), " ", "-")}-wg")
users = concat([for member in wg_data.chairpersons : member.slack], [for member in wg_data.members : member.slack])
users = concat([for member in wg_data.chairpersons : lookup(member, "slack", null)], [for member in wg_data.members : lookup(member, "slack", null)])
}
}
}
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/slack/users/users.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,14 @@ locals {
repos = setunion(flatten([for maintainer in local.maintainers_data : maintainer.repos]))
repo_maintainers = {
for repo in local.repos : repo =>
[for maintainer in local.maintainers_data : maintainer.slack if contains(maintainer.repos, repo)]
[for maintainer in local.maintainers_data : lookup(maintainer, "slack", null) if contains(maintainer.repos, repo)]
}
}

output "data_sources" {
value = {
maintainers_user_ids = [for maintainer in local.maintainers_data : maintainer.slack]
tsc_members_user_ids = [for tsc_member in local.tsc_members_data : tsc_member.slack]
maintainers_user_ids = [for maintainer in local.maintainers_data : lookup(maintainer, "slack", null)]
tsc_members_user_ids = [for tsc_member in local.tsc_members_data : lookup(tsc_member, "slack", null)]
repo_maintainers = local.repo_maintainers
}
}