Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: slack ID made optional. #1677

Merged
merged 5 commits into from
Feb 4, 2025
Merged

fix: slack ID made optional. #1677

merged 5 commits into from
Feb 4, 2025

Conversation

neoandmatrix
Copy link
Contributor

Description

As discussed in the Issue #1658 if slack id is not present we just ignore it hence this PR introduces the changes to allow terraform to correctly parse them if slack ID is not present.

Related issue(s)
#1658

@Shurtu-gal please provide feedback on this approach.
Thanks.

@neoandmatrix
Copy link
Contributor Author

@Shurtu-gal any views on this.
Should i move forward with this to make it a PR or any other cases or factors can be considered.
Thanks.

@Shurtu-gal
Copy link
Contributor

This looks good. One thing could you try running the changes once though. Rest looks LGTM.

@neoandmatrix
Copy link
Contributor Author

neoandmatrix commented Feb 2, 2025 •
edited
Loading

Sure will test it and let you know.
Thanks.

@neoandmatrix
Copy link
Contributor Author

@Shurtu-gal tested the changes locally in my test workspace by removing slackID from one of the member and CI worked perfectly.
Here is the code for same https://github.com/neoandmatrix/terraform
Please confirm then will make this PR ready for review.
Thanks.

@Shurtu-gal
Copy link
Contributor

Yep looks correct.

Shurtu-gal
Shurtu-gal approved these changes Feb 2, 2025
View reviewed changes
Copy link
Contributor

@Shurtu-gal Shurtu-gal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Shurtu-gal
Copy link
Contributor

Please ping the maintainers once for their approval as well.

@neoandmatrix
Copy link
Contributor Author

LGTM

Thanks for review.

@neoandmatrix
Copy link
Contributor Author

Please ping the maintainers once for their approval as well.

Sure , Making this Ready for review.

@neoandmatrix neoandmatrix marked this pull request as ready for review February 2, 2025 16:43
@neoandmatrix
Copy link
Contributor Author

neoandmatrix commented Feb 2, 2025 •
edited
Loading

@derberg @thulieblack @quetzalliwrites Can you please review this PR.
Thanks.

@thulieblack
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit a6db28c into asyncapi:master Feb 4, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thulieblack thulieblack thulieblack approved these changes

@Shurtu-gal Shurtu-gal Shurtu-gal approved these changes

@quetzalliwrites quetzalliwrites Awaiting requested review from quetzalliwrites quetzalliwrites is a code owner

@derberg derberg Awaiting requested review from derberg derberg is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@neoandmatrix @Shurtu-gal @thulieblack @asyncapi-bot