fix: use latest global workflow and remove link checkers #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derberg
requested review from
quetzalliwrites,
fmvilas,
KhudaDad414 and
asyncapi-bot-eve
as code owners
derberg
commented
Mar 27, 2023
There was a problem hiding this comment.
@KhudaDad414 another approval please
I forgot that .github/workflows/link-check-cron.yml,.github/workflows/link-check-pr.yml must stay there as otherwise workflow will ignore removal if there is no pattern that would notice it 🤦🏼
not a big deal, can be removed later from config file if needed
KhudaDad414
approved these changes
Mar 27, 2023
|
/rtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
.github/workflows/link-check-cron.yml,.github/workflows/link-check-pr.ymlare removed from repo and config, bot should remove these check from all the repositories in AsyncAPI orgFixes #199
if someone wants to have these workflows in repository, they should open a separate PR to add these files as separate configuration, that someone can opt-in only by using some specific repository topic name