-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link checker having an insane amount of false positives #199
Comments
tbh, maybe because we left it to fail for too long, but I basically thought for some time already about removing this workflow 🤷🏼 it is causing lot of noise and confusion as well, I guess. @KhudaDad414 wdyt? or maybe we push from here also a global config where by default we ignore checking anchors and accept 429 from GitHub as valid? |
@derberg even if we accept 429 and ignore checking anchors, maintaining repos so they don't have invalid links is a cumbersome task (especially for repos that contain too many links like |
@jonaslagoni what do you think as a maintainer? |
As long as the workflow itself is still producing false positives like this, i would never incorporate it into my own development workflow 😅 |
yeah, true dat @KhudaDad414 I don't know, but I think better would be to leave it per repo, I mean. Maybe have separate configuration, like |
I mean this would be cool but it also adds another niche feature which maintainers need to keep track of. besides, after fixing links in almost 30 repos I can testify that the value that this workflow provides isn't that great compared to the amount of attention it needs or the amount of noise that it generates AND the amount of power it consumes. 😆 |
I thought you have strong opinion to keep it. but now I think you are ok to get it removed what is the final statement then 😏 |
I don't consider |
LOL! we have only one problem, my action for global actions do not yet support "workflow removal detection" and will not create a PR to repos once we remove these workflows from |
@derberg I see we already have an issue for this here. derberg/manage-files-in-multiple-repositories#46 |
finally here #219 @KhudaDad414 once you approve please leave merging too me as I wanna merge it and keep an eye on it to make sure the world will not blow up 😅 |
it worked |
Describe the bug
The link checker workflow: https://github.com/asyncapi/.github/blob/master/.github/workflows/link-check-pr.yml have an insane amount of false positives (where it reports an error when there is none).
False positives it detects:
[something](#Something)
.429
failing workflow when checking contributors based on allcontributors.Example run from Modelina:
The text was updated successfully, but these errors were encountered: