ci: improve release workflows to skip early #198
Conversation
derberg
requested review from
quetzalliwrites,
fmvilas,
KhudaDad414 and
asyncapi-bot-eve
as code owners
| # "commits" contains array of objects where one of the properties is commit "message" | ||
| # Release workflow will be skipped if release conventional commits are not used | ||
| if: | | ||
| startsWith( github.repository, 'asyncapi/' ) && |
There was a problem hiding this comment.
to make sure workflow does not run on forks, to not confuse people
I already had few questions from folks asking why release is failing (but it was running on their forks)
| # Release workflow will be skipped if release conventional commits are not used | ||
| if: | | ||
| startsWith( github.repository, 'asyncapi/' ) && | ||
| (startsWith( github.event.commits[0].message , 'fix:' ) || |
There was a problem hiding this comment.
unfortunately github.event.commits[0].message must be repeated several times. When I added it as global env in workflow, it was not accessed in condition
| (startsWith( github.event.commits[0].message , 'fix:' ) || | ||
| startsWith( github.event.commits[0].message, 'fix!:' ) || | ||
| startsWith( github.event.commits[0].message, 'feat:' ) || | ||
| startsWith( github.event.commits[0].message, 'feat!:' )) |
There was a problem hiding this comment.
unfortunately startsWith has to be done this way, it accepts only string as input for evaluation. In case of contains it accepts array.
There was a problem hiding this comment.
@fmvilas sorry, please approve again. When I was in the sauna yesterday, I was thinking about this workflow and something told me to do some tests on the personal repo. And yeah, as a result, I had to rework the entire condition
|
/rtm |
Description
semantic-releasefinds out release is not neededstartsWith(fromJsonand notcontains(fromJsonlike in other workflows because commit message can be multiline, and we do not have 100% assurance that PR was not manually merged and feat/fix was not mentioned somewhere in the messagestartsWithalso works withcontainsas there is not direct info in docs, at least I did not find it. I just searched github and found https://github.com/insignias/React/blob/main/.github/workflows/merge-release-pr-to-main.yml#L40Related issue(s)
Resolves #184