Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

we should add some custom filter to release workflow #184

Closed
derberg opened this issue Sep 29, 2022 · 1 comment · Fixed by #198
Closed

we should add some custom filter to release workflow #184

derberg opened this issue Sep 29, 2022 · 1 comment · Fixed by #198
Labels
enhancement New feature or request

Comments

@derberg
Copy link
Member

derberg commented Sep 29, 2022

Reason/Context

Release https://github.com/asyncapi/.github/blob/master/.github/workflows/if-nodejs-release.yml relies on semantic-release to answer if release is needed.

This means, on every single commit it runs tests, and then release just to realize at the very end that it was not needed.

Bit waste of resources!

Description

I think we need to make it skip early all jobs if we notice that PR title is different than feat, fix, feat!

what we loose: sometimes (1% of cases) it happens that some releases of features fail, and that another chore commit fixes it, as release runs cause semantic release discovers unreleased feature. It will obviously no longer work as semantic-release will not ever run with this new solution

Thoughts?

@derberg derberg added the enhancement New feature or request label Sep 29, 2022
@smoya
Copy link
Member

smoya commented Sep 29, 2022

+1 to run only if the current commit has any of those prefixes (feat, fix, feat!).

what we loose: sometimes (1% of cases) it happens that some releases of features fail, and that another chore commit fixes it, as release runs cause semantic release discovers unreleased feature. It will obviously no longer work as semantic-release will not ever run with this new solution

If that means we will need to add an extra commit with those prefixes in order to run the release, I'm fine to be honest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants