Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pytest durations from tests #309

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Remove pytest durations from tests #309

merged 1 commit into from
Dec 5, 2024

Conversation

tatiana
Copy link
Collaborator

@tatiana tatiana commented Dec 5, 2024

Even though the --durations flag can be very helpful in debugging and troubleshooting test durations, to have it in a permanent basis adds overhead to the tests and obfuscates us seeing more relevant data, such as coverage report.

Even though the --durations flag can be very helpful in debugging and troubleshooting test durations, to have it in a permanent basis adds overhead to the tests and obfuscates us seeing more relevant data, such as coverage report.
@tatiana tatiana requested a review from a team as a code owner December 5, 2024 11:39
@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.57%. Comparing base (72bc85b) to head (da01c71).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #309   +/-   ##
=======================================
  Coverage   92.57%   92.57%           
=======================================
  Files          10       10           
  Lines         700      700           
=======================================
  Hits          648      648           
  Misses         52       52           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tatiana tatiana merged commit 2e9fd4e into main Dec 5, 2024
67 checks passed
@tatiana tatiana deleted the remove-durations branch December 5, 2024 12:49
@tatiana tatiana mentioned this pull request Dec 6, 2024
tatiana added a commit that referenced this pull request Dec 6, 2024
### Added

- Add support to TaskFlow and improve dynamic task mapping support by
@tatiana in #314
- Render YML DAG config as DAG Docs by @pankajastro #305
- Support building DAGs out of topologically unsorted YAML files by
@tatiana in #307
- Add support for nested task groups by @glazunov996 and @pankajastro in
#292
- Add support for templating `on_failure_callback` by @jroach-astronomer
#252

### Fixed

- Fix compatibility with
apache-airflow-providers-cncf-kubernetes>=10.0.0 by @tatiana in #311
- Refactor telemetry to collect events during DAG run and not during DAG
parsing by @pankajastro #300

### Docs

- Fix reference for HttpSensor in README.md by @pankajastro in #277
- Add example DAG for task group by @pankajastro in #293
- Add CODEOWNERS by @pankajkoti in #270
- Update CODEOWNERS to track all files by @pankajkoti in #276
- Modified Status badge in README by @jaejun #298

### Others

- Refactor dynamic task mapping implementation by @tatiana in #313
- Remove pytest durations from tests by @tatiana in #309
- Remove DAG retries check since many DAGs have different retry values
by @tatiana in #310
- Lint fixes after running `pre-commit run --all-files` by @tatiana in
#312
- Remove redundant exception code by @pankajastro #294
- Add GitHub issue template for bug reports and feature requests by
@pankajkoti in #269

Closes: #223
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants