Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example DAG for task group #293

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Add example DAG for task group #293

merged 1 commit into from
Nov 20, 2024

Conversation

pankajastro
Copy link
Contributor

This PR adds an example for the task group.
Depend on PR: #292

Screenshot 2024-11-19 at 6 23 42 PM

@pankajastro pankajastro self-assigned this Nov 19, 2024
Copy link
Collaborator

@tatiana tatiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy for us to merge this once it's rebased on #292 and the tests are passing, thanks a lot, @pankajastro !

Copy link
Contributor

@pankajkoti pankajkoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as Tatiana said, happy to merge after CI passes & we have the needed implementation from #292 rebased here.

@pankajastro pankajastro force-pushed the example_dag_task_group branch from 1ba6a31 to f1ee37c Compare November 20, 2024 10:48
@pankajastro pankajastro marked this pull request as ready for review November 20, 2024 10:48
@pankajastro pankajastro requested a review from a team as a code owner November 20, 2024 10:48
@pankajastro pankajastro added this to the DAG Factory 0.21.0 milestone Nov 20, 2024
@pankajastro pankajastro merged commit 831a741 into main Nov 20, 2024
67 checks passed
@pankajastro pankajastro deleted the example_dag_task_group branch November 20, 2024 10:50
@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.22%. Comparing base (7626fa6) to head (f1ee37c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #293   +/-   ##
=======================================
  Coverage   93.22%   93.22%           
=======================================
  Files           8        8           
  Lines         664      664           
=======================================
  Hits          619      619           
  Misses         45       45           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@tatiana tatiana mentioned this pull request Dec 6, 2024
tatiana added a commit that referenced this pull request Dec 6, 2024
### Added

- Add support to TaskFlow and improve dynamic task mapping support by
@tatiana in #314
- Render YML DAG config as DAG Docs by @pankajastro #305
- Support building DAGs out of topologically unsorted YAML files by
@tatiana in #307
- Add support for nested task groups by @glazunov996 and @pankajastro in
#292
- Add support for templating `on_failure_callback` by @jroach-astronomer
#252

### Fixed

- Fix compatibility with
apache-airflow-providers-cncf-kubernetes>=10.0.0 by @tatiana in #311
- Refactor telemetry to collect events during DAG run and not during DAG
parsing by @pankajastro #300

### Docs

- Fix reference for HttpSensor in README.md by @pankajastro in #277
- Add example DAG for task group by @pankajastro in #293
- Add CODEOWNERS by @pankajkoti in #270
- Update CODEOWNERS to track all files by @pankajkoti in #276
- Modified Status badge in README by @jaejun #298

### Others

- Refactor dynamic task mapping implementation by @tatiana in #313
- Remove pytest durations from tests by @tatiana in #309
- Remove DAG retries check since many DAGs have different retry values
by @tatiana in #310
- Lint fixes after running `pre-commit run --all-files` by @tatiana in
#312
- Remove redundant exception code by @pankajastro #294
- Add GitHub issue template for bug reports and feature requests by
@pankajkoti in #269

Closes: #223
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants