Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate http async provider #1420

Closed
1 task done
Lee-W opened this issue Jan 2, 2024 · 3 comments · Fixed by #1459
Closed
1 task done

Deprecate http async provider #1420

Lee-W opened this issue Jan 2, 2024 · 3 comments · Fixed by #1459
Assignees
@vatsrahul1001
Labels
feature New feature or request
Milestone
1.19.0

Comments

@Lee-W
Copy link
Contributor

Lee-W commented Jan 2, 2024 •
edited by pankajkoti
Loading

Is your feature request related to a problem? Please describe.

as most of the functionality has been contributed back to OSS airflow, we're going to leverage the code there and deprecate this project

Describe the solution you'd like

  1. Contribute the delta to the OSS provider
  2. Point the astronomer provider to the OSS provider
  3. Do the release and wait for a month or so before we remove the astronomer provider in a major release

Describe alternatives you've considered

Additional context

Current Progress

  • Number of operator changes on OSS airflow needed: 1
  • Number of operators to deprecate: 1
  1. HttpSensorAsync
@Lee-W Lee-W added the feature New feature or request label Jan 2, 2024
@Lee-W Lee-W self-assigned this Jan 2, 2024
@Lee-W Lee-W changed the title Drepcreate http provider Deprecate http async provider Jan 2, 2024
@Lee-W Lee-W added this to the 1.19.0 milestone Jan 19, 2024
@vatsrahul1001 vatsrahul1001 assigned vatsrahul1001 and unassigned Lee-W Jan 22, 2024
@vatsrahul1001
Copy link
Contributor

Raised PR in OSS

@phanikumv
Copy link
Collaborator

@vatsrahul1001 to link the relevant PR for this

@vatsrahul1001 vatsrahul1001 mentioned this issue Jan 29, 2024
Merged
pankajkoti pushed a commit that referenced this issue Jan 29, 2024
@vatsrahul1001 @pre-commit-ci
Deprecate HttpSensorAsync (#1459)
63b0421 
This PR deprecates HttpSensorAsync by proxying them to their Airflow OSS provider's.

closes:#1420
---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@pankajkoti
Copy link
Collaborator

PRs linked and merged. Closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vatsrahul1001 vatsrahul1001

Labels
feature New feature or request
Projects
None yet
Milestone
1.19.0
Development

Successfully merging a pull request may close this issue.

Deprecate HttpSensorAsync astronomer/astronomer-providers
4 participants
@Lee-W @pankajkoti @vatsrahul1001 @phanikumv