Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deferrable implementation in HTTPSensor #36904

Merged
merged 28 commits into from
Jan 23, 2024

Conversation

vatsrahul1001
Copy link
Collaborator

This PR address deferrable logic for HTTPSensor


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@vatsrahul1001 vatsrahul1001 force-pushed the add_deferrable_to_httpsensor branch from 273c92e to b4d6b10 Compare January 19, 2024 16:32
@vatsrahul1001 vatsrahul1001 marked this pull request as ready for review January 19, 2024 16:36
airflow/providers/http/sensors/http.py Outdated Show resolved Hide resolved
airflow/providers/http/sensors/http.py Outdated Show resolved Hide resolved
tests/providers/http/sensors/test_http.py Outdated Show resolved Hide resolved
tests/providers/http/sensors/test_http.py Outdated Show resolved Hide resolved
Copy link
Contributor

@phanikumv phanikumv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider adding docs?

tests/providers/http/sensors/test_http.py Outdated Show resolved Hide resolved
tests/providers/http/sensors/test_http.py Outdated Show resolved Hide resolved
tests/providers/http/sensors/test_http.py Outdated Show resolved Hide resolved
tests/providers/http/sensors/test_http.py Outdated Show resolved Hide resolved
tests/providers/http/sensors/test_http.py Outdated Show resolved Hide resolved
@vatsrahul1001
Copy link
Collaborator Author

consider adding docs?

updated docs with example

Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one minor suggestion but rest looks good to me

docs/apache-airflow-providers-http/operators.rst Outdated Show resolved Hide resolved
tests/system/providers/http/example_http.py Outdated Show resolved Hide resolved
@phanikumv phanikumv merged commit 9596bbd into apache:main Jan 23, 2024
55 checks passed
@phanikumv phanikumv deleted the add_deferrable_to_httpsensor branch January 23, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants