-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deferrable implementation in HTTPSensor #36904
Merged
phanikumv
merged 28 commits into
apache:main
from
astronomer:add_deferrable_to_httpsensor
Jan 23, 2024
Merged
Add deferrable implementation in HTTPSensor #36904
phanikumv
merged 28 commits into
apache:main
from
astronomer:add_deferrable_to_httpsensor
Jan 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vatsrahul1001
requested review from
Lee-W,
phanikumv,
pankajastro and
pankajkoti
January 19, 2024 16:31
vatsrahul1001
force-pushed
the
add_deferrable_to_httpsensor
branch
from
January 19, 2024 16:32
273c92e
to
b4d6b10
Compare
Lee-W
reviewed
Jan 20, 2024
Co-authored-by: Wei Lee <[email protected]>
…airflow into add_deferrable_to_httpsensor
phanikumv
reviewed
Jan 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider adding docs?
Lee-W
reviewed
Jan 22, 2024
Co-authored-by: Wei Lee <[email protected]>
1 task
Lee-W
reviewed
Jan 22, 2024
Co-authored-by: Wei Lee <[email protected]>
…airflow into add_deferrable_to_httpsensor
updated docs with example |
Lee-W
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one minor suggestion but rest looks good to me
phanikumv
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR address deferrable logic for HTTPSensor
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.