Read and write .python-version in the workspace root
#7815
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j178
commented
Sep 30, 2024
Comment on lines
766
to
775
| // TODO: If the version file already exists, but does not contain the requested version, | ||
| // should we update it? (add the version, or replace the existing one) | ||
| // For now, we keep the existing behavior: if the file exists, we don't update it. | ||
| if !version_file.path().try_exists()? { | ||
| version_file | ||
| .clone() | ||
| .with_versions(vec![python_request.clone()]) | ||
| .write() | ||
| .await?; | ||
| } |
There was a problem hiding this comment.
If the version file already exists, but does not contain the requested version, should we update it? (add the version, or replace the existing one)
For now, we keep the existing behavior: if the file exists, we don't update it.
j178
commented
Sep 30, 2024
| .and_then(PythonVersionFile::version) | ||
| .filter(|version| *version != new.version().unwrap()) | ||
| { | ||
| let new = existing.clone().with_versions(vec![request]); |
There was a problem hiding this comment.
Behavior change: uv python pin now updates the discovered version file, rather than always writing to .python-version.
Comment on lines
+135
to
+143
| if existing.contains(&request) { | ||
| writeln!( | ||
| printer.stdout(), | ||
| "`{}` is already pinned at `{}`", | ||
| existing.path().user_display().cyan(), | ||
| request.to_canonical_string().green(), | ||
| )?; | ||
| return Ok(ExitStatus::Success); | ||
| } |
There was a problem hiding this comment.
Behavior change: uv python pin now cross-checks the requested version with all versions in the version file, not just the first one. It also avoids updating the version file if the required version already exists. The message updated to ".python-version is already pinned at 3.12".
j178
changed the title
.python-version in the workspace root
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR modifies
uv initanduv python pinto read and write the Python version file from the discovered workspace root, instead of the current working directory.It also includes some behavioral changes (noted in the self-review comments). The previous behavior seemed erroneous, but if it wasn't, please instruct me to revert these changes.
Resolves #7806