Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't create .python-version in workspace subprojects #7806

Open
bluss opened this issue Sep 30, 2024 · 6 comments
Open

Don't create .python-version in workspace subprojects #7806

bluss opened this issue Sep 30, 2024 · 6 comments
Labels
enhancement New feature or improvement to existing functionality good first issue Good for newcomers

Comments

@bluss
Copy link
Contributor

bluss commented Sep 30, 2024

I suggest that .python-version should not be created in subprojects in a workspace. The workspace root should contain this file already, and subprojects should not have them. The current version of uv creates this file when initing a new workspace member, and the user can/should delete the file afterwards - if I understand correctly.

uv 0.4.17

@charliermarsh
Copy link
Member

This makes sense to me.

@charliermarsh charliermarsh added the enhancement New feature or improvement to existing functionality label Sep 30, 2024
@zanieb zanieb added the good first issue Good for newcomers label Sep 30, 2024
@dimitrivinet
Copy link

First time contributor here, didn't think it would send a message here 😅
Realized I don't have the correct format for the commit message, but how does this look ?

@konstin
Copy link
Member

konstin commented Oct 4, 2024

We don't have a particular format for commit messages, just try to write a short description of what got fixed or what got changed.

(Note that this issue is implemented by #7815)

@zanieb
Copy link
Member

zanieb commented Oct 4, 2024

And this already overlaps with some other in-flight work.

I'm actually not entirely sure about this, since a subproject can have different Python requirements it might make sense to be able to run it on another version? If we moved this metadata into the pyproject.toml would we still ban this?

@bluss
Copy link
Contributor Author

bluss commented Oct 4, 2024

I think that uv init should not create this file because it's very redundant in subfolders of workspaces in my projects. To permit having it/using it - another issue?

@zanieb
Copy link
Member

zanieb commented Oct 4, 2024

Ah I see why I agreed on first read — yes I don't think uv init should create the redundant file. I think uv python pin in a subdirectory is "another question".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement to existing functionality good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants