Check diagnostic refresh support from client capability

[dhruvmanila]

Summary

Per the LSP spec, the property name is workspace.diagnostics with an s at the end but the lsp-types dependency uses workspace.diagnostic (without an s). Our fork contains this fix (astral-sh/lsp-types@0f58d62) so we should avoid the hardcoded value.

The implication of this is that the client which doesn't support workspace refresh capability didn't support the dynamic configuration feature because the server would always send the workspace refresh request but the client would ignore it. We have a fallback logic to publish the diagnostics instead:

ruff/crates/ruff_server/src/server/api/notifications/did_change_watched_files.rs

Lines 28 to 40 in 5f6fc39

	if session.resolved_client_capabilities().workspace_refresh {
	requester
	.request::<types::request::WorkspaceDiagnosticRefresh>((), |()| Task::nothing())
	.with_failure_code(lsp_server::ErrorCode::InternalError)?;
	} else {
	// publish diagnostics for text documents
	for url in session.text_document_urls() {
	let snapshot = session
	.take_snapshot(url.clone())
	.expect("snapshot should be available");
	publish_diagnostics_for_document(&snapshot, &notifier)?;
	}
	}

fixes: #15013

Test Plan

VS Code

Screen.Recording.2024-12-16.at.2.28.32.PM.mov

Neovim

Screen.Recording.2024-12-16.at.3.04.00.PM.mov

[github-actions]

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.