[ruff_python_ast] Add name and default functions to TypeParam. #14964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
AlexWaygood
reviewed
Dec 14, 2024
Comment on lines
+3398
to
+3404
| pub fn default(&self) -> Option<&Expr> { | ||
| match self { | ||
| Self::TypeVar(x) => x.default.as_deref(), | ||
| Self::ParamSpec(x) => x.default.as_deref(), | ||
| Self::TypeVarTuple(x) => x.default.as_deref(), | ||
| } | ||
| } |
There was a problem hiding this comment.
hmm... I see that this could be useful, but the name could be confusing, since most default() methods come from the Default trait. I don't necessarily have a better suggestion, though...!
There was a problem hiding this comment.
I think this is fine, considering that it is aligned with the field name. Default::default is also a static method whereas TypeParam.default is an instance method
Co-authored-by: Alex Waygood <[email protected]>
Glyphack
pushed a commit
to Glyphack/ruff
that referenced
this pull request
Dec 15, 2024
…l-sh#14964) ## Summary This change adds `name` and `default` functions to `TypeParam` to access the corresponding attributes more conveniently. I currently have these as helper functions in code built on top of ruff_python_ast, and they seemed like they might be generally useful. ## Test Plan Ran the checks listed in CONTRIBUTING.md#development. --------- Co-authored-by: Micha Reiser <[email protected]> Co-authored-by: Alex Waygood <[email protected]>
|
Thank you both for the speedy reviews! |
dcreager
added a commit
that referenced
this pull request
Dec 16, 2024
* main: (25 commits) [`pydocstyle`] Skip leading whitespace for `D403` (#14963) Update pre-commit dependencies (#15008) Check diagnostic refresh support from client capability (#15014) Update Rust crate colored to v2.2.0 (#15010) Update dependency monaco-editor to v0.52.2 (#15006) Update Rust crate thiserror to v2.0.7 (#15005) Update Rust crate serde to v1.0.216 (#15004) Update Rust crate libc to v0.2.168 (#15003) Update Rust crate fern to v0.7.1 (#15002) Update Rust crate chrono to v0.4.39 (#15001) Update Rust crate bstr to v1.11.1 (#15000) Update NPM Development dependencies (#14999) Update dependency ruff to v0.8.3 (#15007) Pin mdformat plugins in pre-commit (#14992) Use stripping block (`|-`) for page descriptions (#14980) [`perflint`] Fix panic in `perf401` (#14971) Improve the documentation of E201/E202 (#14983) [ruff_python_ast] Add name and default functions to TypeParam. (#14964) [red-knot] Emit an error if a bare `Annotated` or `Literal` is used in a type expression (#14973) [red-knot] Fix bugs relating to assignability of dynamic `type[]` types (#14972) ...
facebook-github-bot
pushed a commit
to facebook/pyre-check
that referenced
this pull request
Dec 16, 2024
Summary: Did a ruff upgrade in order to pull in astral-sh/ruff#14964. Reviewed By: ndmitchell Differential Revision: D67299113 fbshipit-source-id: 38c9075e403a25e29802369343b86e0c1219b8c2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change adds
nameanddefaultfunctions toTypeParamto access the corresponding attributes more conveniently. I currently have these as helper functions in code built on top of ruff_python_ast, and they seemed like they might be generally useful.Test Plan
Ran the checks listed in CONTRIBUTING.md#development.