This repository has been archived by the owner on Nov 22, 2018. It is now read-only.
Use private instance of MemoryCache and impose size limit #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JunTaoLuo
commented
Jul 10, 2017
| @@ -11,7 +11,7 @@ public interface IResponseCache | |||
| IResponseCacheEntry Get(string key); | |||
| Task<IResponseCacheEntry> GetAsync(string key); | |||
|
|
|||
| void Set(string key, IResponseCacheEntry entry, TimeSpan validFor); | |||
| Task SetAsync(string key, IResponseCacheEntry entry, TimeSpan validFor); | |||
| void Set(string key, IResponseCacheEntry entry, TimeSpan validFor, long size); | |||
There was a problem hiding this comment.
Looking into refactoring the helpers to the interface does not change.
JunTaoLuo
commented
Jul 10, 2017
| options, | ||
| loggerFactory, | ||
| policyProvider, | ||
| new MemoryResponseCache(new MemoryCache(new MemoryCacheOptions |
There was a problem hiding this comment.
Alternatively, we can add the MemoryResponseCache to DI but have it resolve ResponseCachingOptions to figure out the size.
JunTaoLuo
commented
Jul 10, 2017
| @@ -9,6 +9,11 @@ namespace Microsoft.AspNetCore.ResponseCaching | |||
| public class ResponseCachingOptions | |||
| { | |||
| /// <summary> | |||
| /// The size limit for the response cache middleware in bytes. The default is set to 100 MB. | |||
| /// </summary> | |||
| public long SizeLimit { get; set; } = 100 * 1024 * 1024; | |||
There was a problem hiding this comment.
Should we have ResponseCachingOptions extend MemoryCacheOptions so other options can be set?
Tratcher
reviewed
Jul 10, 2017
| // Body | ||
| if (cachedResponse.Body != null) | ||
| { | ||
| size += cachedResponse.Body.Length * sizeof(char); |
Tratcher
reviewed
Jul 10, 2017
| context.CachedResponseValidFor, | ||
| EstimateCachedResponseSize(context.CachedResponse)); | ||
| } | ||
| catch (OverflowException) { } |
There was a problem hiding this comment.
don't bother, we'll run out of RAM first.
JunTaoLuo
force-pushed
the
johluo/size-limit
branch
2 times, most recently
from
bb3867c to
2614ab0
Compare
|
🆙📅 |
Tratcher
approved these changes
Jul 10, 2017
JunTaoLuo
force-pushed
the
johluo/size-limit
branch
from
2614ab0 to
f125329
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #127 Still need to add some tests.