Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AddResponseCaching unnecessarily adds IMemoryCache to the DI #3360

Closed
JunTaoLuo opened this issue Jul 26, 2018 · 1 comment
Closed

AddResponseCaching unnecessarily adds IMemoryCache to the DI #3360

JunTaoLuo opened this issue Jul 26, 2018 · 1 comment
Assignees
@JunTaoLuo
Labels
area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlesware breaking-change This issue / pr will introduce a breaking change, when resolved / merged. bug This issue describes a behavior which is not expected - a bug. Done This issue has been fixed feature-response-caching
Milestone
3.0.0-preview1

Comments

@JunTaoLuo
Copy link
Contributor

The response caching middleware used to rely on the memory cache from the DI until we decided to use a private instance of memory cache: aspnet/ResponseCaching#132. As such we no longer need to add IMemoryCache to the DI services as part of AddResponseCaching.
@JunTaoLuo JunTaoLuo added bug This issue describes a behavior which is not expected - a bug. 2 - Working feature-response-caching labels Jul 26, 2018
@JunTaoLuo JunTaoLuo self-assigned this Jul 26, 2018
@JunTaoLuo JunTaoLuo added this to the 3.0.0 milestone Jul 26, 2018
@JunTaoLuo JunTaoLuo mentioned this issue Jul 26, 2018
Merged
@Eilon Eilon added the breaking-change This issue / pr will introduce a breaking change, when resolved / merged. label Jul 26, 2018
@Eilon
Copy link
Member

Eilon commented Jul 26, 2018

Marking as breaking-change, even though no one should have relied on this behavior anyway. No need for an announcement at this time.

@JunTaoLuo JunTaoLuo added Done This issue has been fixed and removed 2 - Working labels Jul 27, 2018
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
@amcasey amcasey added the area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlesware label Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JunTaoLuo JunTaoLuo

Labels
area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlesware breaking-change This issue / pr will introduce a breaking change, when resolved / merged. bug This issue describes a behavior which is not expected - a bug. Done This issue has been fixed feature-response-caching
Projects
None yet
Milestone
3.0.0-preview1
Development

No branches or pull requests
3 participants
@Eilon @JunTaoLuo @amcasey