This repository has been archived by the owner on Nov 22, 2018. It is now read-only.
Update how certain cache directives are handled #83
Comments
JunTaoLuo
added a commit
that referenced
this issue
Jan 10, 2017
- Always add IresponseCachingFeatu8re before calling the next middleware #81 - Use If-Modified-Since instead of the incorrect If-Unmodified-Since header #83 - Handle proxy-revalidate in the same way as must-revalidate #83 - Handle max-stale with no specified limit #83 - Bypass cache lookup for no-cache but store the response #83 - Bypass response capturing and buffering when no-store is specified #83 - Replace IsRequestCacheable cache policy with three new independent policy checks to reflect these changes
JunTaoLuo
added a commit
that referenced
this issue
Jan 10, 2017
- Always add IresponseCachingFeatu8re before calling the next middleware #81 - Use If-Modified-Since instead of the incorrect If-Unmodified-Since header #83 - Handle proxy-revalidate in the same way as must-revalidate #83 - Handle max-stale with no specified limit #83 - Bypass cache lookup for no-cache but store the response #83 - Bypass response capturing and buffering when no-store is specified #83 - Replace IsRequestCacheable cache policy with three new independent policy checks to reflect these changes - Modify middleware flow to accommodate cache policy updates
JunTaoLuo
added a commit
that referenced
this issue
Jan 10, 2017
- Always add IresponseCachingFeatu8re before calling the next middleware #81 - Use If-Modified-Since instead of the incorrect If-Unmodified-Since header #83 - Handle proxy-revalidate in the same way as must-revalidate #83 - Handle max-stale with no specified limit #83 - Bypass cache lookup for no-cache but store the response #83 - Bypass response capturing and buffering when no-store is specified #83 - Replace IsRequestCacheable cache policy with three new independent policy checks to reflect these changes - Modify middleware flow to accommodate cache policy updates
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
no-storeon request:This should by-pass
ShimResponseStreamsince we can't store any part of the response so there's no point in capturing the responseno-cacheon request:We can "validate" by asking the server to regenerate the response. As such we shouldn't skip the capturing of the response and update the cache entry if possible.
max-staleThe case where no limit is specified, which means any stale response can be served, is not handled.
proxy-revalidateSame effect as
must-revalidateAlso the header
If-Unmodified-Sinceis being used incorrectly. The correct header to check for in when determining if content is modified isIf-Modified-SinceThe text was updated successfully, but these errors were encountered: