Skip to content
This repository has been archived by the owner on Nov 22, 2018. It is now read-only.

Port fix for Update how certain cache directives are handled to 1.0.x #89

Closed
JunTaoLuo opened this issue Dec 22, 2016 · 6 comments
Closed

Port fix for Update how certain cache directives are handled to 1.0.x #89

JunTaoLuo opened this issue Dec 22, 2016 · 6 comments
Assignees
@JunTaoLuo
Labels
3 - Done bug patch-approved
Milestone
1.0.1

Comments

@JunTaoLuo
Copy link
Contributor

JunTaoLuo commented Dec 22, 2016 •
edited
Loading

The fix for #83 needs to go into LTS 1.0.x branch.
@JunTaoLuo JunTaoLuo self-assigned this Dec 22, 2016
@JunTaoLuo JunTaoLuo changed the title Port fix for Cache-Control: no-cache breaks the middleware to 1.0.x Port fix for Update how certain cache directives are handled to 1.0.x Dec 22, 2016
@JunTaoLuo JunTaoLuo added this to the 1.0.0 milestone Jan 10, 2017
@JunTaoLuo JunTaoLuo added the bug label Jan 10, 2017
@JunTaoLuo
Copy link
Contributor Author

JunTaoLuo commented Jan 10, 2017 •
edited
Loading

Need to discuss which parts of the fixes in #88 needs to be back ported to 1.0.x

At the minimum, we'll need the fix for using If-Modified-Since instead of the incorrect If-Unmodified-Since.

We can potentially also add the handling of proxy-revalidate, and max-stale with no specified limit since those are low risk but they are not critical. May also consider porting the fix for #81 for consistency but it's not used by MVC since the ResponseCacheAttribute is a 1.1 feature.

@JunTaoLuo
Copy link
Contributor Author

cc @muratg

@muratg muratg modified the milestones: 1.0.4, 1.0.0, 1.0.1 Jan 10, 2017
@muratg
Copy link
Contributor

muratg commented Jan 11, 2017

(Setting milestone to 1.0.1 to reflect the actual package version to be shipped.)

@Eilon
Copy link
Member

Eilon commented Jan 19, 2017

This patch bug is approved. Please use the normal code review process w/ a PR and make sure the fix is in the correct branch, then close the bug and mark it as done.

@JunTaoLuo JunTaoLuo mentioned this issue Jan 21, 2017
Merged
@JunTaoLuo
Copy link
Contributor Author

JunTaoLuo commented Jan 23, 2017 •
edited
Loading

Patch merged. Leaving the issue open since version numbers will need to be updated.

@JunTaoLuo
Copy link
Contributor Author

Version numbers updated

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JunTaoLuo JunTaoLuo

Labels
3 - Done bug patch-approved
Projects
None yet
Milestone
1.0.1
Development

No branches or pull requests
3 participants
@Eilon @muratg @JunTaoLuo