Skip to content
This repository has been archived by the owner on Dec 19, 2018. It is now read-only.

API namespace cleanup for tag helpers #578

Closed
Eilon opened this issue Oct 19, 2015 · 5 comments
Closed

API namespace cleanup for tag helpers #578

Eilon opened this issue Oct 19, 2015 · 5 comments
Assignees
@NTaylorMullen
Labels
3 - Done enhancement
Milestone
1.0.0-rc1

Comments

@Eilon
Copy link
Member

Eilon commented Oct 19, 2015

From a meeting with @dougbu @rynowak @DamianEdwards

Move what’s in the Microsoft.AspNet.Razor.TagHelpers namespace to something like
Microsoft.AspNet.Razor.Compilation.TagHelpers.

And move what's in the Microsoft.AspNet.Razor.Runtime.TagHelpers namespace to Microsoft.AspNet.Razor.TagHelpers. An alternative that we considered was to rename it to Microsoft.AspNet.Html.TagHelpers, because it's not really Razor-specific, but meh.
@Eilon Eilon added this to the 4.0.0-rc1 milestone Oct 19, 2015
NTaylorMullen added a commit that referenced this issue Oct 20, 2015
@NTaylorMullen
Rename Microsoft.AspNet.Razor.TagHelpers.
fc7eabf 
- Name changed to `Microsoft.AspNet.Razor.Compilation.TagHelpers`.
- Changed folder locations to reflect namespace change.

#578
NTaylorMullen added a commit that referenced this issue Oct 20, 2015
@NTaylorMullen
Rename Microsoft.AspNet.Razor.Runtime.TagHelpers.
c0ebd43 
- Changed name to `Microsoft.AspNet.Razor.TagHelpers`.
- Updated folder structure to reflect new namespaces.
- Updated generated code files to reflect new runtime type namespaces.

#578
@NTaylorMullen NTaylorMullen mentioned this issue Oct 20, 2015
Merged
NTaylorMullen added a commit that referenced this issue Oct 20, 2015
@NTaylorMullen
Moved all invalid TagHelper utilities out of `Microsoft.AspNet.Razo…
466bff1 
…r.TagHelpers`.

- Required adding a new using statement to generated code. Regened output files.
- Fixed broken documentation.

#578
NTaylorMullen added a commit that referenced this issue Oct 20, 2015
@NTaylorMullen
Rename Microsoft.AspNet.Razor.TagHelpers.
deb0624 
- Name changed to `Microsoft.AspNet.Razor.Compilation.TagHelpers`.
- Changed folder locations to reflect namespace change.

#578
NTaylorMullen added a commit that referenced this issue Oct 20, 2015
@NTaylorMullen
Rename Microsoft.AspNet.Razor.Runtime.TagHelpers.
e035895 
- Changed name to `Microsoft.AspNet.Razor.TagHelpers`.
- Updated folder structure to reflect new namespaces.
- Updated generated code files to reflect new runtime type namespaces.

#578
NTaylorMullen added a commit that referenced this issue Oct 20, 2015
@NTaylorMullen
Moved all invalid TagHelper utilities out of `Microsoft.AspNet.Razo…
997a9bd 
…r.TagHelpers`.

- Required adding a new using statement to generated code. Regened output files.
- Fixed broken documentation.

#578
NTaylorMullen added a commit that referenced this issue Oct 20, 2015
@NTaylorMullen
Normalize Runtime namespaces into two distinct namespaces.
9f1b244 
- Disable `TagHelper` infrastructure using statements during design time.
- Regenerated code files.

#578
NTaylorMullen added a commit that referenced this issue Oct 21, 2015
@NTaylorMullen
Rename Microsoft.AspNet.Razor.TagHelpers.
6352b36 
- Name changed to `Microsoft.AspNet.Razor.Compilation.TagHelpers`.
- Changed folder locations to reflect namespace change.

#578
NTaylorMullen added a commit that referenced this issue Oct 21, 2015
@NTaylorMullen
Rename Microsoft.AspNet.Razor.Runtime.TagHelpers.
a8dfd3f 
- Changed non-ser facing type names to `Microsoft.AspNet.Razor.TagHelpers`.
- Updated folder structure to reflect new namespaces.
- Updated generated code files to reflect new runtime type namespaces.

#578
NTaylorMullen added a commit that referenced this issue Oct 21, 2015
@NTaylorMullen
Rename Microsoft.AspNet.Razor.Runtime.TagHelpers.
bfa4057 
- Changed non-user facing type names to `Microsoft.AspNet.Razor.TagHelpers`.
- Updated folder structure to reflect new namespaces.
- Updated generated code files to reflect new runtime type namespaces.

#578
NTaylorMullen added a commit that referenced this issue Oct 22, 2015
@NTaylorMullen
Rename Microsoft.AspNet.Razor.TagHelpers.
bd2a98e 
- Name changed to `Microsoft.AspNet.Razor.Compilation.TagHelpers`.
- Changed folder locations to reflect namespace change.

#578
NTaylorMullen added a commit that referenced this issue Oct 22, 2015
@NTaylorMullen
Rename Microsoft.AspNet.Razor.Runtime.TagHelpers.
b1ad14f 
- Changed non-user facing type names to `Microsoft.AspNet.Razor.TagHelpers`.
- Updated folder structure to reflect new namespaces.
- Updated generated code files to reflect new runtime type namespaces.

#578
NTaylorMullen added a commit to aspnet/Mvc that referenced this issue Oct 22, 2015
@NTaylorMullen
React to aspnet/Razor#578.
0e25470
@NTaylorMullen
Copy link
Contributor

bd2a98e
b1ad14f
6a7082d
aspnet/Mvc@0e25470
aspnet/Mvc@9b9d72f
aspnet/RazorTooling@0a62707

NTaylorMullen added a commit to aspnet/RazorTooling that referenced this issue Oct 22, 2015
@NTaylorMullen
React to aspnet/Razor#578.
0a62707 
- Updated namespaces.
@dougbu
Copy link
Member

dougbu commented Oct 22, 2015

aspnet/Mvc@0e25470 leaves references to Microsoft.AspNet.Razor.Runtime.TagHelpers in the LinkTagHelper and ScriptTagHelper. Either unused usings were not removed or this issue should be reopened and the dangling type moved to Microsoft.AspNet.Razor.TagHelpers.

Who reviewed that commit BTW? I don't remember a PR for it.

@NTaylorMullen
Copy link
Contributor

It was a reaction. Shouldn't need a review. As for them having Runtime.TagHelpers. That's due to them creating new DefaultTagHelperContents

@dougbu
Copy link
Member

dougbu commented Oct 22, 2015

If they need to do that, others will as well. DefaultTagHelperContent is not in the correct namespace yet.

@dougbu dougbu reopened this Oct 22, 2015
NTaylorMullen added a commit that referenced this issue Oct 22, 2015
@NTaylorMullen
Move DefaultTagHelperContent from Razor.Runtime.TagHelpers to `Ra…
6a7082d 
…zor.TagHelpers`.

#578
NTaylorMullen added a commit to aspnet/Mvc that referenced this issue Oct 22, 2015
@NTaylorMullen
Remove unneeded namespaces.
9b9d72f 
aspnet/Razor#578
@NTaylorMullen
Copy link
Contributor

Moved DefaultTagHelperContent to Razor.TagHelpers

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NTaylorMullen NTaylorMullen

Labels
3 - Done enhancement
Projects
None yet
Milestone
1.0.0-rc1
Development

No branches or pull requests
3 participants
@Eilon @NTaylorMullen @dougbu