Moved all invalid TagHelper utilities out of `Microsoft.AspNet.Razo…

…r.TagHelpers`.

- Required adding a new using statement to generated code. Regened output files.
- Fixed broken documentation.

#578

src/Microsoft.AspNet.Razor.Runtime.Precompilation/CodeAnalysisSymbolBasedPropertyInfo.cs

@@ -4,7 +4,7 @@
 using System;
 using System.Collections.Generic;
 using System.Diagnostics;
-using Microsoft.AspNet.Razor.TagHelpers;
+using Microsoft.AspNet.Razor.Runtime.TagHelpers.Internal;
 using Microsoft.CodeAnalysis;
 
 namespace Microsoft.AspNet.Razor.Runtime.Precompilation

src/Microsoft.AspNet.Razor.Runtime.Precompilation/CodeAnalysisSymbolBasedTypeInfo.cs

@@ -7,7 +7,7 @@
 using System.Linq;
 using System.Reflection;
 using System.Text;
-using Microsoft.AspNet.Razor.TagHelpers;
+using Microsoft.AspNet.Razor.Runtime.TagHelpers.Internal;
 using Microsoft.CodeAnalysis;
 
 namespace Microsoft.AspNet.Razor.Runtime.Precompilation

src/Microsoft.AspNet.Razor.Runtime.Precompilation/PrecompilationTagHelperTypeResolver.cs

@@ -4,7 +4,7 @@
 using System;
 using System.Collections.Generic;
 using System.Reflection;
-using Microsoft.AspNet.Razor.TagHelpers;
+using Microsoft.AspNet.Razor.Runtime.TagHelpers.Internal;
 using Microsoft.CodeAnalysis;
 
 namespace Microsoft.AspNet.Razor.Runtime.Precompilation

src/Microsoft.AspNet.Razor.Runtime/Constants.cs → src/Microsoft.AspNet.Razor.Runtime/Internal/Constants.cs

@@ -3,7 +3,7 @@
 
 using System;
 
-namespace Microsoft.AspNet.Razor.Runtime
+namespace Microsoft.AspNet.Razor.Runtime.Internal
 {
     internal static class Constants
     {

src/Microsoft.AspNet.Razor.Runtime/XMLDocumentationProvider.cs → src/Microsoft.AspNet.Razor.Runtime/Internal/XMLDocumentationProvider.cs

@@ -9,7 +9,7 @@
 using System.Text;
 using System.Xml.Linq;
 
-namespace Microsoft.AspNet.Razor.Runtime
+namespace Microsoft.AspNet.Razor.Runtime.Internal
 {
     /// <summary>
     /// Extracts summary and remarks XML documentation from an XML documentation file.

src/Microsoft.AspNet.Razor.Runtime/TagHelpers/DefaultTagHelperContent.cs → src/Microsoft.AspNet.Razor.Runtime/TagHelpers/Internal/DefaultTagHelperContent.cs

@@ -6,10 +6,11 @@
 using System.IO;
 using System.Text;
 using Microsoft.AspNet.Html.Abstractions;
+using Microsoft.AspNet.Razor.TagHelpers;
 using Microsoft.Extensions.Internal;
 using Microsoft.Extensions.WebEncoders;
 
-namespace Microsoft.AspNet.Razor.TagHelpers
+namespace Microsoft.AspNet.Razor.Runtime.TagHelpers.Internal
 {
     /// <summary>
     /// Default concrete <see cref="TagHelperContent"/>.

src/Microsoft.AspNet.Razor.Runtime/TagHelpers/IMemberInfo.cs → src/Microsoft.AspNet.Razor.Runtime/TagHelpers/Internal/IMemberInfo.cs

@@ -4,7 +4,7 @@
 using System;
 using System.Collections.Generic;
 
-namespace Microsoft.AspNet.Razor.TagHelpers
+namespace Microsoft.AspNet.Razor.Runtime.TagHelpers.Internal
 {
     /// <summary>
     /// Metadata common to types and properties.

src/Microsoft.AspNet.Razor.Runtime/TagHelpers/IPropertyInfo.cs → src/Microsoft.AspNet.Razor.Runtime/TagHelpers/Internal/IPropertyInfo.cs

@@ -1,7 +1,7 @@
 // Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
-namespace Microsoft.AspNet.Razor.TagHelpers
+namespace Microsoft.AspNet.Razor.Runtime.TagHelpers.Internal
 {
     /// <summary>
     /// Contains property metadata.

src/Microsoft.AspNet.Razor.Runtime/TagHelpers/ITypeInfo.cs → src/Microsoft.AspNet.Razor.Runtime/TagHelpers/Internal/ITypeInfo.cs

@@ -4,7 +4,7 @@
 using System;
 using System.Collections.Generic;
 
-namespace Microsoft.AspNet.Razor.TagHelpers
+namespace Microsoft.AspNet.Razor.Runtime.TagHelpers.Internal
 {
     /// <summary>
     /// Contains type metadata.
@@ -27,9 +27,9 @@ public interface ITypeInfo : IMemberInfo, IEquatable<ITypeInfo>
         /// Gets <see cref="IPropertyInfo"/>s for all properties of the current type excluding indexers.
         /// </summary>
         /// <remarks>
-        /// Indexers in this context refer to the CLR notion of an indexer (<c>this [string name]</c> 
-        /// and does not overlap with the semantics of 
-        /// <see cref="Razor.Compilation.TagHelperAttributeDescriptor.IsIndexer"/>.
+        /// Indexers in this context refer to the CLR notion of an indexer (<c>this [string name]</c>
+        /// and does not overlap with the semantics of
+        /// <see cref="Razor.Compilation.TagHelpers.TagHelperAttributeDescriptor.IsIndexer"/>.
         /// </remarks>
         IEnumerable<IPropertyInfo> Properties { get; }
 
@@ -62,7 +62,7 @@ public interface ITypeInfo : IMemberInfo, IEquatable<ITypeInfo>
         /// parameters if the type implements <see cref="IDictionary{TKey, TValue}"/>, otherwise <c>null</c>.
         /// </returns>
         /// <remarks>
-        /// For open generic types, <see cref="ITypeInfo" /> for generic type parameters is <c>null</c>. 
+        /// For open generic types, <see cref="ITypeInfo" /> for generic type parameters is <c>null</c>.
         /// </remarks>
         ITypeInfo[] GetGenericDictionaryParameters();
     }

src/Microsoft.AspNet.Razor.Runtime/TagHelpers/RuntimePropertyInfo.cs → src/Microsoft.AspNet.Razor.Runtime/TagHelpers/Internal/RuntimePropertyInfo.cs

@@ -4,9 +4,8 @@
 using System;
 using System.Collections.Generic;
 using System.Reflection;
-using Microsoft.AspNet.Razor.TagHelpers;
 
-namespace Microsoft.AspNet.Razor.Runtime
+namespace Microsoft.AspNet.Razor.Runtime.TagHelpers.Internal
 {
     /// <summary>
     /// <see cref="IPropertyInfo"/> adapter for <see cref="PropertyInfo"/> instances.

src/Microsoft.AspNet.Razor.Runtime/TagHelpers/RuntimeTypeInfo.cs → src/Microsoft.AspNet.Razor.Runtime/TagHelpers/Internal/RuntimeTypeInfo.cs

@@ -6,10 +6,11 @@
 using System.Linq;
 using System.Reflection;
 using System.Text.RegularExpressions;
-using Microsoft.AspNet.Razor.Runtime;
+using Microsoft.AspNet.Razor.Runtime.Internal;
+using Microsoft.AspNet.Razor.TagHelpers;
 using Microsoft.Extensions.Internal;
 
-namespace Microsoft.AspNet.Razor.TagHelpers
+namespace Microsoft.AspNet.Razor.Runtime.TagHelpers.Internal
 {
     /// <summary>
     /// <see cref="ITypeInfo"/> adapter for <see cref="System.Reflection.TypeInfo"/> instances.

src/Microsoft.AspNet.Razor.Runtime/TagHelpers/TagHelperDescriptorFactory.cs → src/Microsoft.AspNet.Razor.Runtime/TagHelpers/Internal/TagHelperDescriptorFactory.cs

@@ -8,9 +8,10 @@
 using System.Reflection;
 using System.Text.RegularExpressions;
 using Microsoft.AspNet.Razor.Compilation.TagHelpers;
-using Microsoft.AspNet.Razor.Runtime;
+using Microsoft.AspNet.Razor.Runtime.Internal;
+using Microsoft.AspNet.Razor.TagHelpers;
 
-namespace Microsoft.AspNet.Razor.TagHelpers
+namespace Microsoft.AspNet.Razor.Runtime.TagHelpers.Internal
 {
     /// <summary>
     /// Factory for <see cref="TagHelperDescriptor"/>s from <see cref="ITypeInfo"/>s.

src/Microsoft.AspNet.Razor.Runtime/TagHelpers/TagHelperDescriptorResolver.cs → src/Microsoft.AspNet.Razor.Runtime/TagHelpers/Internal/TagHelperDescriptorResolver.cs

@@ -5,12 +5,10 @@
 using System.Collections.Generic;
 using System.Diagnostics;
 using System.Linq;
-using System.Text.RegularExpressions;
-using Microsoft.AspNet.Razor.Parser;
 using Microsoft.AspNet.Razor.Compilation.TagHelpers;
-using Microsoft.AspNet.Razor.Runtime;
+using Microsoft.AspNet.Razor.Parser;
 
-namespace Microsoft.AspNet.Razor.TagHelpers
+namespace Microsoft.AspNet.Razor.Runtime.TagHelpers.Internal
 {
     /// <summary>
     /// Used to resolve <see cref="TagHelperDescriptor"/>s.
@@ -117,16 +115,16 @@ public IEnumerable<TagHelperDescriptor> Resolve(TagHelperDescriptorResolutionCon
         }
 
         /// <summary>
-        /// Resolves all <see cref="TagHelperDescriptor"/>s for <see cref="ITagHelper"/>s from the given
-        /// <paramref name="assemblyName"/>.
+        /// Resolves all <see cref="TagHelperDescriptor"/>s for <see cref="Razor.TagHelpers.ITagHelper"/>s from the
+        /// given <paramref name="assemblyName"/>.
         /// </summary>
         /// <param name="assemblyName">
         /// The name of the assembly to resolve <see cref="TagHelperDescriptor"/>s from.
         /// </param>
         /// <param name="documentLocation">The <see cref="SourceLocation"/> of the directive.</param>
         /// <param name="errorSink">Used to record errors found when resolving <see cref="TagHelperDescriptor"/>s
         /// within the given <paramref name="assemblyName"/>.</param>
-        /// <returns><see cref="TagHelperDescriptor"/>s for <see cref="ITagHelper"/>s from the given
+        /// <returns><see cref="TagHelperDescriptor"/>s for <see cref="Razor.TagHelpers.ITagHelper"/>s from the given
         /// <paramref name="assemblyName"/>.</returns>
         // This is meant to be overridden by tooling to enable assembly level caching.
         protected virtual IEnumerable<TagHelperDescriptor> ResolveDescriptorsInAssembly(

src/Microsoft.AspNet.Razor.Runtime/TagHelpers/TagHelperDesignTimeDescriptorFactory.cs → src/Microsoft.AspNet.Razor.Runtime/TagHelpers/Internal/TagHelperDesignTimeDescriptorFactory.cs

@@ -9,9 +9,10 @@
 using System.Linq;
 using System.Reflection;
 using Microsoft.AspNet.Razor.Compilation.TagHelpers;
-using Microsoft.AspNet.Razor.Runtime;
+using Microsoft.AspNet.Razor.Runtime.Internal;
+using Microsoft.AspNet.Razor.TagHelpers;
 
-namespace Microsoft.AspNet.Razor.TagHelpers
+namespace Microsoft.AspNet.Razor.Runtime.TagHelpers.Internal
 {
     /// <summary>
     /// Factory for providing <see cref="TagHelperDesignTimeDescriptor"/>s from <see cref="Type"/>s and

src/Microsoft.AspNet.Razor.Runtime/TagHelpers/TagHelperExecutionContext.cs → src/Microsoft.AspNet.Razor.Runtime/TagHelpers/Internal/TagHelperExecutionContext.cs

@@ -4,8 +4,9 @@
 using System;
 using System.Collections.Generic;
 using System.Threading.Tasks;
+using Microsoft.AspNet.Razor.TagHelpers;
 
-namespace Microsoft.AspNet.Razor.TagHelpers
+namespace Microsoft.AspNet.Razor.Runtime.TagHelpers.Internal
 {
     /// <summary>
     /// Class used to store information about a <see cref="ITagHelper"/>'s execution lifetime.

src/Microsoft.AspNet.Razor.Runtime/TagHelpers/TagHelperRunner.cs → src/Microsoft.AspNet.Razor.Runtime/TagHelpers/Internal/TagHelperRunner.cs

@@ -4,8 +4,9 @@
 using System;
 using System.Linq;
 using System.Threading.Tasks;
+using Microsoft.AspNet.Razor.TagHelpers;
 
-namespace Microsoft.AspNet.Razor.TagHelpers
+namespace Microsoft.AspNet.Razor.Runtime.TagHelpers.Internal
 {
     /// <summary>
     /// A class used to run <see cref="ITagHelper"/>s.

src/Microsoft.AspNet.Razor.Runtime/TagHelpers/TagHelperScopeManager.cs → src/Microsoft.AspNet.Razor.Runtime/TagHelpers/Internal/TagHelperScopeManager.cs

@@ -4,10 +4,10 @@
 using System;
 using System.Collections.Generic;
 using System.Threading.Tasks;
-using Microsoft.AspNet.Razor.Runtime;
+using Microsoft.AspNet.Razor.TagHelpers;
 using Microsoft.Extensions.Internal;
 
-namespace Microsoft.AspNet.Razor.TagHelpers
+namespace Microsoft.AspNet.Razor.Runtime.TagHelpers.Internal
 {
     /// <summary>
     /// Class that manages <see cref="TagHelperExecutionContext"/> scopes.

src/Microsoft.AspNet.Razor.Runtime/TagHelpers/TagHelperTypeResolver.cs → src/Microsoft.AspNet.Razor.Runtime/TagHelpers/Internal/TagHelperTypeResolver.cs

@@ -5,9 +5,9 @@
 using System.Collections.Generic;
 using System.Linq;
 using System.Reflection;
-using Microsoft.AspNet.Razor.Runtime;
+using Microsoft.AspNet.Razor.TagHelpers;
 
-namespace Microsoft.AspNet.Razor.TagHelpers
+namespace Microsoft.AspNet.Razor.Runtime.TagHelpers.Internal
 {
     /// <summary>
     /// Class that locates valid <see cref="ITagHelper"/>s within an assembly.

src/Microsoft.AspNet.Razor.Runtime/TagHelpers/TagHelperOutput.cs

@@ -2,6 +2,7 @@
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
 using System;
+using Microsoft.AspNet.Razor.Runtime.TagHelpers.Internal;
 
 namespace Microsoft.AspNet.Razor.TagHelpers
 {

src/Microsoft.AspNet.Razor/Chunks/AddTagHelperChunk.cs

@@ -4,12 +4,12 @@
 namespace Microsoft.AspNet.Razor.Chunks
 {
     /// <summary>
-    /// A <see cref="Chunk"/> used to look up <see cref="Compilation.TagHelperDescriptor"/>s.
+    /// A <see cref="Chunk"/> used to look up <see cref="Compilation.TagHelpers.TagHelperDescriptor"/>s.
     /// </summary>
     public class AddTagHelperChunk : Chunk
     {
         /// <summary>
-        /// Text used to look up <see cref="Compilation.TagHelperDescriptor"/>s.
+        /// Text used to look up <see cref="Compilation.TagHelpers.TagHelperDescriptor"/>s.
         /// </summary>
         public string LookupText { get; set; }
     }

src/Microsoft.AspNet.Razor/Chunks/Generators/AddOrRemoveTagHelperChunkGenerator.cs

@@ -15,7 +15,7 @@ public class AddOrRemoveTagHelperChunkGenerator : SpanChunkGenerator
         /// Instantiates a new <see cref="AddOrRemoveTagHelperChunkGenerator"/>.
         /// </summary>
         /// <param name="lookupText">
-        /// Text used to look up <see cref="Compilation.TagHelperDescriptor"/>s that should be added or removed.
+        /// Text used to look up <see cref="Compilation.TagHelpers.TagHelperDescriptor"/>s that should be added or removed.
         /// </param>
         public AddOrRemoveTagHelperChunkGenerator(bool removeTagHelperDescriptors, string lookupText)
         {
@@ -24,13 +24,13 @@ public AddOrRemoveTagHelperChunkGenerator(bool removeTagHelperDescriptors, strin
         }
 
         /// <summary>
-        /// Gets the text used to look up <see cref="Compilation.TagHelperDescriptor"/>s that should be added to or
+        /// Gets the text used to look up <see cref="Compilation.TagHelpers.TagHelperDescriptor"/>s that should be added to or
         /// removed from the Razor page.
         /// </summary>
         public string LookupText { get; }
 
         /// <summary>
-        /// Whether we want to remove <see cref="Compilation.TagHelperDescriptor"/>s from the Razor page.
+        /// Whether we want to remove <see cref="Compilation.TagHelpers.TagHelperDescriptor"/>s from the Razor page.
         /// </summary>
         /// <remarks>If <c>true</c> <see cref="GenerateChunk"/> generates <see cref="AddTagHelperChunk"/>s,
         /// <see cref="RemoveTagHelperChunk"/>s otherwise.</remarks>

src/Microsoft.AspNet.Razor/Chunks/RemoveTagHelperChunk.cs

@@ -4,13 +4,13 @@
 namespace Microsoft.AspNet.Razor.Chunks
 {
     /// <summary>
-    /// A <see cref="Chunk"/> used to look up <see cref="Compilation.TagHelperDescriptor"/>s that should be ignored
+    /// A <see cref="Chunk"/> used to look up <see cref="Compilation.TagHelpers.TagHelperDescriptor"/>s that should be ignored
     /// within the Razor page.
     /// </summary>
     public class RemoveTagHelperChunk : Chunk
     {
         /// <summary>
-        /// Text used to look up <see cref="Compilation.TagHelperDescriptor"/>s that should be ignored within the Razor
+        /// Text used to look up <see cref="Compilation.TagHelpers.TagHelperDescriptor"/>s that should be ignored within the Razor
         /// page.
         /// </summary>
         public string LookupText { get; set; }

src/Microsoft.AspNet.Razor/CodeGenerators/Visitors/CSharpUsingVisitor.cs

@@ -11,7 +11,11 @@ namespace Microsoft.AspNet.Razor.CodeGenerators.Visitors
 {
     public class CSharpUsingVisitor : CodeVisitor<CSharpCodeWriter>
     {
-        private const string TagHelpersRuntimeNamespace = "Microsoft.AspNet.Razor.TagHelpers";
+        private static readonly string[] TagHelpersRuntimeNamespaces = new[]
+        {
+            "Microsoft.AspNet.Razor.TagHelpers",
+            "Microsoft.AspNet.Razor.Runtime.TagHelpers.Internal"
+        };
 
         private bool _foundTagHelpers;
 
@@ -93,11 +97,15 @@ protected override void Visit(TagHelperChunk chunk)
             {
                 _foundTagHelpers = true;
 
-                if (!ImportedUsings.Contains(TagHelpersRuntimeNamespace))
+                foreach (var tagHelperRuntimeNamespace in TagHelpersRuntimeNamespaces)
                 {
-                    // If we find TagHelpers then we need to add the TagHelper runtime namespace to our list of usings.
-                    Writer.WriteUsing(TagHelpersRuntimeNamespace);
-                    ImportedUsings.Add(TagHelpersRuntimeNamespace);
+                    if (!ImportedUsings.Contains(tagHelperRuntimeNamespace))
+                    {
+                        // If we find TagHelpers then we need to add the TagHelper runtime namespaces to our list of
+                        // usings.
+                        Writer.WriteUsing(tagHelperRuntimeNamespace);
+                        ImportedUsings.Add(tagHelperRuntimeNamespace);
+                    }
                 }
             }
         }

test/Microsoft.AspNet.Razor.Runtime.Precompilation.Test/PrecompilationTagHelperDescriptorFactoryTest.cs

@@ -4,8 +4,8 @@
 using System;
 using System.Collections.Generic;
 using System.Linq;
-using Microsoft.AspNet.Razor.TagHelpers;
 using Microsoft.AspNet.Razor.Compilation.TagHelpers;
+using Microsoft.AspNet.Razor.Runtime.TagHelpers.Internal;
 using Microsoft.AspNet.Razor.Test.Internal;
 using Xunit;
 

test/Microsoft.AspNet.Razor.Runtime.Precompilation.Test/PrecompilationTagHelperTypeResolverTest.cs

@@ -7,6 +7,7 @@
 using System.ComponentModel.DataAnnotations;
 using System.Linq;
 using System.Reflection;
+using Microsoft.AspNet.Razor.Runtime.TagHelpers.Internal;
 using Microsoft.AspNet.Razor.TagHelpers;
 using Microsoft.AspNet.Testing;
 using Microsoft.CodeAnalysis.CSharp;

test/Microsoft.AspNet.Razor.Runtime.Test/TagHelpers/DefaultTagHelperContentTest.cs

@@ -1,14 +1,13 @@
 // Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
-using System;
 using System.Globalization;
 using System.IO;
-using Microsoft.AspNet.Testing;
+using Microsoft.AspNet.Razor.TagHelpers;
 using Microsoft.Extensions.WebEncoders.Testing;
 using Xunit;
 
-namespace Microsoft.AspNet.Razor.TagHelpers
+namespace Microsoft.AspNet.Razor.Runtime.TagHelpers.Internal
 {
     public class DefaultTagHelperContentTest
     {
@@ -102,7 +101,7 @@ public void CanAppendFormatContent()
                 "HtmlEncode[[First]] HtmlEncode[[Second]] HtmlEncode[[Third]] HtmlEncode[[Fourth]]!",
                 tagHelperContent.GetContent(new CommonTestEncoder()));
         }
-        
+
         [Fact]
         public void CanAppendFormat_WithCulture()
         {
@@ -173,7 +172,7 @@ public void IsModified_TrueAfterSetContent()
             Assert.True(tagHelperContent.IsModified);
         }
 
-        
+
         [Fact]
         public void IsModified_TrueAfterAppend()
         {