This repository has been archived by the owner on Dec 14, 2018. It is now read-only.
Handle broader range of collection types in model binding #2946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @rynowak |
| { | ||
| return newCollection?.ToArray(); | ||
| return collection?.ToArray(); |
There was a problem hiding this comment.
Will the default case here be that the model is already an array? What are the cases we might get here and have it not be an array?
There was a problem hiding this comment.
It'll never be an array since the base CollectionModelBinder uses a List<TElement> until it needs to copy everything into the final model. The value should not be null but this was written defensively originally...
There was a problem hiding this comment.
Cool! Can you add that info to a comment here?
|
⌚ overall looks good, tests look good. |
- #2793 - add `ICollectionModelBinder`, allowing `GenericModelBinder` to call `CreateEmptyCollection()` - adjust `CollectionModelBinder` and `DictionaryModelBinder` to activate model if default types are incompatible - do not create default (empty) top-level collection in fallback case if Model already non-`null` - change type checks in `GenericModelBinder` to align with `CollectionModelBinder` capabilities - add special case for `IEnumerable<T>` - correct `ModelMetadata` of a few tests that previously did not need that information
- did stuff
dougbu
force-pushed
the
dougbu/concrete.collections.2793
branch
from
2033030 to
4311c87
Compare
|
Updated |
| { | ||
| Debug.Assert(targetType == typeof(TElement[]), "GenericModelBinder only creates this binder for arrays."); | ||
|
|
||
| return true; |
There was a problem hiding this comment.
Why just do the thing you put in the assert? You could say with like 20 characters what all of this does, and technically be more correct 😆
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ICollectionModelBinder, allowingGenericModelBinderto callCreateEmptyCollection()CollectionModelBinderandDictionaryModelBinderto activate model if default types are incompatiblenullGenericModelBinderto align withCollectionModelBindercapabilitiesIEnumerable<T>ModelMetadataof a few tests that previously did not need that information