Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

Concrete Collection types don't work with GenericModelBinder #2793

Closed
kulmugdha opened this issue Jul 8, 2015 · 1 comment
Closed

Concrete Collection types don't work with GenericModelBinder #2793

kulmugdha opened this issue Jul 8, 2015 · 1 comment
Assignees
@dougbu
Labels
3 - Done bug feature-Model-Binding
Milestone
1.0.0-beta7

Comments

@kulmugdha
Copy link
Contributor

If the parameter is Concrete Collection type, the GetCollectionBinder in GenericModelBinder doesn't get CollectionBinder for this type.
@pranavkm pranavkm mentioned this issue Jul 9, 2015
Closed
@danroth27 danroth27 added this to the 6.0.0-beta7 milestone Jul 20, 2015
dougbu added a commit that referenced this issue Aug 10, 2015
@dougbu
Handle broader range of collection types in model binding
2033030 
- #2793
- add `ICollectionModelBinder`, allowing `GenericModelBinder` to call `CreateEmptyCollection()`
- adjust `CollectionModelBinder` and `DictionaryModelBinder` to activate model if default types are incompatible
 - do not create default (empty) top-level collection in fallback case if Model already non-`null`
- change type checks in `GenericModelBinder` to align with `CollectionModelBinder` capabilities
 - add special case for `IEnumerable<T>`
- correct `ModelMetadata` of a few tests that previously did not need that information
@dougbu dougbu mentioned this issue Aug 10, 2015
Closed
dougbu added a commit that referenced this issue Aug 11, 2015
@dougbu
Handle broader range of collection types in model binding
8790124 
- #2793
- add `ICollectionModelBinder`, allowing `GenericModelBinder` to call `CreateEmptyCollection()`
- adjust `CollectionModelBinder` and `DictionaryModelBinder` to activate model if default types are incompatible
 - do not create default (empty) top-level collection in fallback case if Model already non-`null`
- change type checks in `GenericModelBinder` to align with `CollectionModelBinder` capabilities
 - add special case for `IEnumerable<T>`
- correct `ModelMetadata` of a few tests that previously did not need that information
dougbu added a commit that referenced this issue Aug 11, 2015
@dougbu
Handle broader range of collection types in model binding
d45e2ee 
- #2793
- add `ICollectionModelBinder`, allowing `GenericModelBinder` to call `CreateEmptyCollection()`
- adjust `CollectionModelBinder` and `DictionaryModelBinder` to activate model if default types are incompatible
 - do not create default (empty) top-level collection in fallback case if Model already non-`null`
- change type checks in `GenericModelBinder` to align with `CollectionModelBinder` capabilities
 - add special case for `IEnumerable<T>`
- correct `ModelMetadata` of a few tests that previously did not need that information
@dougbu
Copy link
Member

dougbu commented Aug 11, 2015

d45e2ee

@dougbu dougbu closed this as completed Aug 11, 2015
@dougbu dougbu mentioned this issue Aug 18, 2015
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dougbu dougbu

Labels
3 - Done bug feature-Model-Binding
Projects
None yet
Milestone
1.0.0-beta7
Development

No branches or pull requests
3 participants
@danroth27 @dougbu @kulmugdha