WIP: HttpsConnectionMiddleware #2849
Conversation
| certificateRequired = true; | ||
| } | ||
|
|
||
| using (var cancellationTokeSource = new CancellationTokenSource(_options.HandshakeTimeout)) |
There was a problem hiding this comment.
This is no longer using IConnectionTimeout since it's added only added in HttpConnection.ProcessRequestAsync
| // Set the list of protocols from listen options | ||
| httpsOptions.HttpProtocols = listenOptions.Protocols; | ||
| listenOptions.ConnectionAdapters.Add(new HttpsConnectionAdapter(httpsOptions, loggerFactory)); | ||
| httpsOptions.MaxInputBufferSize = listenOptions.KestrelServerOptions?.Limits.MaxRequestBufferSize; |
There was a problem hiding this comment.
This isn't great but it was the only way I could think of flowing the limits
davidfowl
force-pushed
the
davidfowl/https-middleware
branch
from
6cc9b8d to
0c2fdaa
Compare
|
@dotnet-bot test OSX 10.12 Release Build |
davidfowl
force-pushed
the
davidfowl/https-middleware
branch
from
0c2fdaa to
81edae2
Compare
|
|
||
| namespace Microsoft.AspNetCore.Server.Kestrel.Https.Internal | ||
| { | ||
| public class HttpsConnectionMiddleware |
There was a problem hiding this comment.
hi @davidfowl can I use this middleware to get tls support for the connection abstraction based mqtt handler I created?
(does this work with tcp or is http(s) required)
There was a problem hiding this comment.
Yes the idea is to have a TlsMiddleware that's separate from Kestrel that can be placed in front of any ConnectionHandler. This is the first go to do that within Kestrel itself to see what issues exist.
Porting the HttpsConnectionAdapter to HttpConnectionMiddleware. There are a few things that are interesting: