-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert Https connection adapter to connection middleware #4623
Comments
Related: aspnet/KestrelHttpServer#1665 |
@davidfowl assigning to you as the other Connection Adapter bug is also assigned to you. |
@davidfowl I believe you're working on this currently. |
(Please see the edit above) |
I'm going to take another stab at this. |
Milestone: @davidfowl (aka |
Old version aspnet/KestrelHttpServer#2849 |
@davidfowl should we add this to #10869? |
Sure. |
My use case is a little more complicated, because I wanted to implement
The other way (from |
This is done. I'll file another issue for exposing a pure TLS middleware, we did the bare minimum to migrate Kestrel's HTTPS IConnectionAdapter to middleware, it'll likely be identical to the TLS middleware (we'll build it on top). |
As part of bedrock, connection adapters are going away and we should port the tls connection adapter to middleware. We don't want to break the public API of the existing extension method on ListenOptions so that will remain.
The true TLS implementation should be in Microsoft.AspNetCore.Protocols.Tls and Kestrel.Tls should delegate to it in the implementation.
Edit: Also convert Logging connection adapter to middleware.
The text was updated successfully, but these errors were encountered: