This repository has been archived by the owner on Dec 18, 2018. It is now read-only.
Remove ListenOptions.Scheme and move IConnectionAdapter to .Internal namespace #1664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
natemcmaster
changed the title
|
🆙 📅 - moved IConnectionAdapter to .Internal and add |
davidfowl
reviewed
Apr 13, 2017
| @@ -145,6 +145,10 @@ public void Start<TContext>(IHttpApplication<TContext> application) | |||
| { | |||
| throw new InvalidOperationException($"HTTPS endpoints can only be configured using {nameof(KestrelServerOptions)}.{nameof(KestrelServerOptions.Listen)}()."); | |||
| } | |||
| else if (!parsedAddress.Scheme.Equals("http", StringComparison.OrdinalIgnoreCase)) | |||
| { | |||
| throw new InvalidOperationException($"Unrecognized scheme in server address '{address}'. Only 'http://' is supported."); | |||
There was a problem hiding this comment.
Is there a test for this case?
There was a problem hiding this comment.
There is now :)
natemcmaster
force-pushed
the
namc/server-addresses
branch
from
4628162 to
1cf6858
Compare
…amespace Add an internal API to ListenOptions to determine if an endpoint is configured to use HTTPS. This is a temporary as the design of connection adapters and configuration will churn before release.
natemcmaster
force-pushed
the
namc/server-addresses
branch
from
1cf6858 to
ed4a27a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We know for sure we don't want ListenOptions.Scheme as public API when we release 2.0, so let's get rid of it now.
This fixes #1296.
Resolves #1495
This is obviously a temporary fix as the design of connection adapters and configuration will churn before release. I will open a follow-up issue to create a better design.