Skip to content
This repository has been archived by the owner on Dec 18, 2018. It is now read-only.

Move IConnectionFilter to internal namespace #1495

Closed
davidfowl opened this issue Mar 15, 2017 · 4 comments
Closed

Move IConnectionFilter to internal namespace #1495

davidfowl opened this issue Mar 15, 2017 · 4 comments
Assignees

Comments

@davidfowl
Copy link
Member

This API is going to change a bunch so we should internalize it.

@Drawaes
Copy link
Contributor

Drawaes commented Mar 15, 2017

So you can't write connection filters anymore? I have them in prod so there will be a version of released kestrel that can't be extended?

@davidfowl
Copy link
Member Author

So you can't write connection filters anymore? I have them in prod so there will be a version of released kestrel that can't be extended?

It's already broken in 2.0. We could keep them public and break them again in the next version but I'd rather not do that. The .Internal namespace lets you write filters but tells you this isn't the final API.

@Drawaes
Copy link
Contributor

Drawaes commented Mar 15, 2017

Ahh so .internal but not internal class modifier... cool have at it

@muratg
Copy link
Contributor

muratg commented Mar 20, 2017

@DamianEdwards Are you OK with this? This will prevent breaking users (again) when we expose pipelines in the future.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants