This repository has been archived by the owner on Dec 18, 2018. It is now read-only.
Always flush headers on first response write (#1202). #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cesarblum
approved these changes
Nov 8, 2016
| "", | ||
| ""); | ||
|
|
||
| flushed.Release(); |
|
Check AppVeyor before merging. |
pranavkm
reviewed
Nov 8, 2016
| using (var server = new TestServer(async httpContext => | ||
| { | ||
| httpContext.Response.ContentLength = 12; | ||
| await httpContext.Response.WriteAsync("hello, world"); | ||
| await flushed.WaitAsync(); |
There was a problem hiding this comment.
Can you add reasonable timeouts to the semaphore Waits?
There was a problem hiding this comment.
These calls to WaitAsync() are in the web app on the test. If the web app hangs, the test will not hang. Instead the test will fail when it times out waiting for a response. The response timeout here is 1 minute like for most of our tests.
|
When the failing test (ThrowingSynchronousConnectionFilterDoesNotCrashServer) is run individually (using |
|
@pranavkm Are you fine with me merging this? |
halter73
force-pushed
the
halter73/1202
branch
from
3d1e5a4 to
840c96c
Compare
|
|
halter73
force-pushed
the
halter73/1202
branch
from
840c96c to
3c7e7d1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1202