Skip to content
This repository has been archived by the owner on Dec 18, 2018. It is now read-only.

Attempting to write to HEAD response hangs the request #1202

Closed
cesarblum opened this issue Nov 7, 2016 · 1 comment
Closed

Attempting to write to HEAD response hangs the request #1202

cesarblum opened this issue Nov 7, 2016 · 1 comment
Assignees
Milestone

Comments

@cesarblum
Copy link
Contributor

cesarblum commented Nov 7, 2016

Run the sample app without any connection filters and send a HEAD request and leave the connection open (this part is important). The client will hang waiting for a response.

This issue was introduced in e7e6b89 when we started ignoring writes to HEAD responses. The problem is that writing a response will make Frame.HasResponseStarted true, skipping the call to ProduceEndAwaited from ProduceEnd and therefore skipping the flush call in that method.

I caught this while working on #1139. When I changed all tests to call Send instead of SendEnd, ResponseTests.HeadResponseCanContainContentLengthHeaderButBodyNotWritten started timing out on TestConnection.Receive.

@muratg
Copy link
Contributor

muratg commented Nov 8, 2016

Approved by @Eilon, so triaging this one in.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants