Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support --noEmit for type-checking as a validation action #681

Merged
merged 8 commits into from
Sep 7, 2024
Merged

feat: support --noEmit for type-checking as a validation action #681

merged 8 commits into from
Sep 7, 2024

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented Sep 4, 2024 •
edited by alexeagle
Loading

Add support for type-checking using validation actions when the ts noEmit option is used.

In the future this validation action can be used for other cases where tsc is only being used for type-checking.

fixes #88

Changes are visible to end-users: no

Test plan

  • Covered by existing test cases
  • New test cases added

@jbedard jbedard changed the title Starting to support validate tsc action feat: support --noEmit for type-checking as a validation action Sep 4, 2024
@jbedard jbedard force-pushed the prototype/validations branch 3 times, most recently from a2220ed to 4fd4720 Compare September 4, 2024 22:11
@aspect-workflows Aspect Workflows
Copy link

aspect-workflows bot commented Sep 4, 2024 •
edited
Loading

Test

All tests were cache hits

84 tests (100.0%) were fully cached saving 8s.

Buildifier      Format

@jbedard jbedard force-pushed the prototype/validations branch 9 times, most recently from 3622686 to 74a2ad6 Compare September 4, 2024 23:38
@jbedard jbedard force-pushed the prototype/validations branch 9 times, most recently from 3c67022 to 652e569 Compare September 5, 2024 08:33
@jbedard jbedard marked this pull request as ready for review September 5, 2024 08:45
@alexeagle alexeagle mentioned this pull request Sep 5, 2024
Closed
alexeagle
alexeagle reviewed Sep 5, 2024
View reviewed changes
ts/defs.bzl Show resolved Hide resolved
alexeagle
alexeagle reviewed Sep 5, 2024
View reviewed changes
ts/private/ts_project.bzl Outdated Show resolved Hide resolved
alexeagle
alexeagle reviewed Sep 5, 2024
View reviewed changes
ts/private/ts_project.bzl Outdated Show resolved Hide resolved
alexeagle
alexeagle reviewed Sep 5, 2024
View reviewed changes
Copy link
Member

@alexeagle alexeagle left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, it's the right next step. I like the simplicity that noEmit == use validation action.

Note that I added a couple commits on the branch, so avoid force-push please

@jbedard jbedard requested a review from alexeagle September 5, 2024 21:31
@jbedard jbedard force-pushed the prototype/validations branch from 428e74b to a57a1b9 Compare September 5, 2024 22:45
alexeagle
alexeagle reviewed Sep 6, 2024
View reviewed changes
ts/private/ts_project.bzl Outdated Show resolved Hide resolved
@jbedard jbedard requested a review from alexeagle September 6, 2024 23:16
@jbedard jbedard enabled auto-merge (rebase) September 7, 2024 00:28
@jbedard jbedard merged commit b719a67 into aspect-build:main Sep 7, 2024
23 checks passed
@jbedard jbedard deleted the prototype/validations branch September 7, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeagle alexeagle alexeagle approved these changes

@thesayyn thesayyn Awaiting requested review from thesayyn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typecheck-only rule
3 participants
@jbedard @alexeagle @jacobgardner