Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typecheck-only rule #88

Closed
alexeagle opened this issue Jul 11, 2022 · 0 comments · Fixed by #681
Closed

Typecheck-only rule #88

alexeagle opened this issue Jul 11, 2022 · 0 comments · Fixed by #681
Labels
bazel 6 Requires features / fixes landed in Bazel 6 enhancement New feature or request

Comments

@alexeagle
Copy link
Member

So far we told users they have to use tsc_test if they just want a rule that errors when .d.ts inputs have typing errors. That's because Bazel won't run actions whose outputs aren't needed, and there are no outputs of a ts_project(srcs=["foo.d.ts"]) where we just want the typechecker to run.

But Bazel 6 has validation actions, as observed here #85 (comment)
so then we could have a typecheck-only rule, maybe it would be ts_project with some different behavior.

@gregmagolan gregmagolan added the bazel 6 Requires features / fixes landed in Bazel 6 label Aug 10, 2022
@gregmagolan gregmagolan added this to the 1.1 milestone Aug 10, 2022
@cgrindel cgrindel added enhancement New feature or request prioritized labels Sep 27, 2022
@gregmagolan gregmagolan moved this to 🔖 Ready in Open Source Feb 5, 2023
@gregmagolan gregmagolan removed this from the 1.1 milestone Feb 5, 2023
jbedard added a commit to jbedard/rules_ts that referenced this issue Aug 29, 2024
jbedard added a commit to jbedard/rules_ts that referenced this issue Aug 29, 2024
jbedard added a commit to jbedard/rules_ts that referenced this issue Aug 29, 2024
jbedard added a commit to jbedard/rules_ts that referenced this issue Aug 29, 2024
jbedard added a commit to jbedard/rules_ts that referenced this issue Aug 29, 2024
jbedard added a commit to jbedard/rules_ts that referenced this issue Aug 29, 2024
jbedard added a commit to jbedard/rules_ts that referenced this issue Sep 5, 2024
jbedard added a commit to jbedard/rules_ts that referenced this issue Sep 5, 2024
jbedard added a commit to jbedard/rules_ts that referenced this issue Sep 5, 2024
jbedard added a commit that referenced this issue Sep 7, 2024
@github-project-automation github-project-automation bot moved this from On Deck to ✅ Done in Open Source Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bazel 6 Requires features / fixes landed in Bazel 6 enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants