feat: add ts_project(deps) validation ensuring all deps of declarations #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbedard
force-pushed
the
30-no-declaration-error
branch
2 times, most recently
from
be39f7d to
05ad849
Compare
thesayyn
reviewed
Oct 27, 2022
thesayyn
reviewed
Oct 27, 2022
alexeagle
reviewed
Oct 31, 2022
|
There are some cases where the right answer to green this up is to turn off the validator. Possibly just do it in all cases as long as they don't look like a bug. |
jbedard
force-pushed
the
30-no-declaration-error
branch
2 times, most recently
from
d7e9a1c to
ce1b0a0
Compare
jbedard
commented
Oct 31, 2022
alexeagle
reviewed
Oct 31, 2022
jbedard
force-pushed
the
30-no-declaration-error
branch
from
ce48d5c to
e97c479
Compare
alexeagle
reviewed
Oct 31, 2022
alexeagle
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on aspect-build/rules_js#563
Some errors fixed when the above PR is merged, others we need to discuss...
TODO: add test requiring disabling validation(modified existing one)