Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give better error when a ts_project dep didn't produce declarations #30

Closed
alexeagle opened this issue Jun 2, 2022 · 1 comment
Closed

Give better error when a ts_project dep didn't produce declarations #30

alexeagle opened this issue Jun 2, 2022 · 1 comment
Assignees
@jbedard
Labels
enhancement New feature or request
Milestone
1.0

Comments

@alexeagle
Copy link
Member

alexeagle commented Jun 2, 2022 •
edited by jbedard
Loading

TypeScript's default for declaration is false, but in Bazel we typically have dependencies on a library and want to type-check usages so maybe we want to change that default?
@alexeagle alexeagle self-assigned this Jun 2, 2022
@gregmagolan
Copy link
Member

Sounds reasonable if there is no extends

@gregmagolan gregmagolan added this to the 1.0 milestone Aug 10, 2022
@gregmagolan gregmagolan added the enhancement New feature or request label Aug 10, 2022
@cgrindel cgrindel assigned jbedard and unassigned alexeagle Oct 11, 2022
@jbedard jbedard mentioned this issue Oct 12, 2022
Merged
@alexeagle alexeagle changed the title Should tsconfig={} result in declaration=True Give better error when a ts_project dep didn't produce declarations Oct 14, 2022
jbedard added a commit to jbedard/rules_ts that referenced this issue Oct 17, 2022
@jbedard
feat: enable declarations by default when unspecified in tsconfig dict
e288938 
Fix aspect-build#30
jbedard added a commit to jbedard/rules_ts that referenced this issue Oct 17, 2022
@jbedard
feat: enable declarations by default when unspecified in tsconfig dict
095114f 
Fix aspect-build#30
@jbedard jbedard mentioned this issue Oct 17, 2022
Closed
jbedard added a commit to jbedard/rules_ts that referenced this issue Oct 17, 2022
@jbedard
feat: enable declarations by default when unspecified in tsconfig dict
eb3eff8 
Fix aspect-build#30
jbedard added a commit to jbedard/rules_ts that referenced this issue Oct 17, 2022
@jbedard
feat: enable declarations by default when unspecified in tsconfig dict
0635943 
Fix aspect-build#30
jbedard added a commit to jbedard/rules_ts that referenced this issue Oct 27, 2022
@jbedard
feat: add ts_project(deps) validation ensuring all deps of declarations
fad7777 
Fix aspect-build#30
jbedard added a commit to jbedard/rules_ts that referenced this issue Oct 27, 2022
@jbedard
feat: add ts_project(deps) validation ensuring all deps of declarations
be39f7d 
Fix aspect-build#30
jbedard added a commit to jbedard/rules_ts that referenced this issue Oct 27, 2022
@jbedard
feat: add ts_project(deps) validation ensuring all deps of declarations
05ad849 
Fix aspect-build#30
jbedard added a commit to jbedard/rules_ts that referenced this issue Oct 31, 2022
@jbedard
feat: add ts_project(deps) validation ensuring all deps of declarations
c5a5b69 
Fix aspect-build#30
jbedard added a commit to jbedard/rules_ts that referenced this issue Oct 31, 2022
@jbedard
feat: add ts_project(deps) validation ensuring all deps of declarations
f887f8e 
Fix aspect-build#30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbedard jbedard

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

feat: enable declarations by default when unspecified in tsconfig dict jbedard/rules_ts
3 participants
@alexeagle @jbedard @gregmagolan