feat: enable declarations by default when unspecified in tsconfig dict #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbedard
force-pushed
the
30-default-declarations
branch
from
095114f to
eb3eff8
Compare
jbedard
force-pushed
the
30-default-declarations
branch
from
eb3eff8 to
0635943
Compare
thesayyn
reviewed
Oct 17, 2022
| @@ -291,6 +291,9 @@ def ts_project( | |||
| tsconfig = "tsconfig.json" | |||
|
|
|||
| if type(tsconfig) == type(dict()): | |||
| # Output declarations by default if unspecified and not extending a config which may specify | |||
| declaration = False if declaration == False or extends else True | |||
There was a problem hiding this comment.
had to read four times to understand the outcome 🗡️
There was a problem hiding this comment.
Have a recommendation or preference to use instead?
|
We decided to create a better error message instead of sometimes overriding the tsconfig, see the change to #30 I'll open a new PR... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #30