-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pnpm): support npm: aliases to packages in alternate registries #1770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbedard
force-pushed
the
npm-registried-alias
branch
from
May 31, 2024 00:30
a778ff5
to
fbba1a2
Compare
jbedard
force-pushed
the
npm-registried-alias
branch
from
May 31, 2024 00:33
fbba1a2
to
30ec9e1
Compare
jbedard
commented
May 31, 2024
jbedard
force-pushed
the
npm-registried-alias
branch
2 times, most recently
from
May 31, 2024 03:16
9b00547
to
0fc4264
Compare
jbedard
force-pushed
the
npm-registried-alias
branch
from
May 31, 2024 03:27
0fc4264
to
f1d5e0d
Compare
jbedard
commented
May 31, 2024
jbedard
commented
May 31, 2024
gregmagolan
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes include:
registry.npmjs.com/
prefix (broke in the last PR)npm:
(like specifiers) instead of/
prefixes (/alias/version
was v5,/alias@version
was v6,alias@version
is v9 and no longer has the distinguishing prefix so I switched tonpm:
in our internal structs).Added tests for each of those cases across lockfile versions.
Changes are visible to end-users: no
Test plan