fix(pnpm): various npm package aliases

e2e/pnpm_lockfiles/BUILD.bazel

@@ -1,3 +1,6 @@
 # gazelle:exclude **/snapshots/**/*
 
-exports_files(["base/patched-dependencies-test.js"])
+exports_files([
+    "base/patched-dependencies-test.js",
+    "base/aliases-test.js",
+])

e2e/pnpm_lockfiles/base/aliases-test.js

@@ -0,0 +1,24 @@
+// `@aspect-test/{a,a2}` should be importable and equal
+if (require('@aspect-test/a') !== require('@aspect-test/a2')) {
+    throw new Error(
+        'aliased `@aspect-test/a` as `@aspect-test/a2` are not the same'
+    )
+}
+
+// `alias-types-node` and `@types/node` should be importable and equal
+if (
+    require('alias-types-node/package.json') !==
+    require('@types/node/package.json')
+) {
+    throw new Error(
+        'aliased `@types/node` as `alias-types-node` is not the same'
+    )
+}
+
+// `is-odd` and the aliased `is-odd-alt-version` should be different versions
+if (
+    require('is-odd/package.json').version ===
+    require('is-odd-alt-version/package.json').version
+) {
+    throw new Error('aliased `is-odd` as `is-odd-alt-version` are the same')
+}

e2e/pnpm_lockfiles/base/package.json

@@ -10,6 +10,7 @@
         "rollup": "3.2.5",
         "meaning-of-life": "1.0.0",
         "is-odd": "3.0.1",
+        "is-odd-alt-version": "npm:is-odd@^2.0.0",
         "uvu": "0.5.6",
         "@scoped/a": "workspace:*",
         "@scoped/b": "link:../projects/b",
@@ -19,7 +20,8 @@
     "devDependencies": {
         "@aspect-test/b": "5.0.2",
         "@types/node": "16.18.11",
-        "@types/archiver": "5.3.1"
+        "@types/archiver": "5.3.1",
+        "alias-types-node": "npm:@types/node@~16.18.11"
     },
     "optionalDependencies": {
         "@aspect-test/c": "2.0.0"

e2e/pnpm_lockfiles/lockfile-test.bzl

@@ -39,11 +39,13 @@ def lockfile_test(name = None):
     lock_version = name if name else native.package_name()
     lock_repo = "lock-%s" % lock_version
 
-    copy_file(
-        name = "copy-tests",
-        src = "//:base/patched-dependencies-test.js",
-        out = "patched-dependencies-test.js",
-    )
+    # Copy each test to this lockfile dir
+    for test in ["patched-dependencies-test.js", "aliases-test.js"]:
+        copy_file(
+            name = "copy-{}".format(test),
+            src = "//:base/{}".format(test),
+            out = test,
+        )
 
     js_test(
         name = "patch-test",
@@ -53,6 +55,19 @@ def lockfile_test(name = None):
         entry_point = "patched-dependencies-test.js",
     )
 
+    js_test(
+        name = "aliases-test",
+        data = [
+            ":node_modules/@aspect-test/a",
+            ":node_modules/@aspect-test/a2",
+            ":node_modules/@types/node",
+            ":node_modules/alias-types-node",
+            ":node_modules/is-odd",
+            ":node_modules/is-odd-alt-version",
+        ],
+        entry_point = "aliases-test.js",
+    )
+
     build_test(
         name = "targets",
         targets = [
@@ -89,10 +104,15 @@ def lockfile_test(name = None):
             # Odd git/http versions
             ":node_modules/debug",
             ":node_modules/hello",
-            # ":node_modules/jsonify", TODO: v9
+            ":node_modules/jsonify",
 
-            # npm:
+            # npm: alias
             ":node_modules/@aspect-test/a2",
+            # npm: alias to registry-scoped packages
+            ":node_modules/alias-types-node",
+            # npm: alias to alternate versions
+            ":node_modules/is-odd-alt-version",
+            ":.aspect_rules_js/node_modules/[email protected]",
 
             # Targets within the virtual store...
             # Direct dep targets