Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove npm_translate_lock(use_starlark_yaml_parser) #1658

Merged
merged 1 commit into from
Apr 19, 2024
Merged

refactor: remove npm_translate_lock(use_starlark_yaml_parser) #1658

merged 1 commit into from
Apr 19, 2024

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented Apr 19, 2024

No description provided.

@jbedard jbedard requested a review from gregmagolan April 19, 2024 04:18
@aspect-workflows Aspect Workflows
Copy link

aspect-workflows bot commented Apr 19, 2024 •
edited
Loading

Test

Buildkite build #3217 is running...

Test

e2e/bzlmod

Buildkite build #3217 is running...

Test

e2e/gyp_no_install_script

Buildkite build #3217 is running...

Test

e2e/js_image_oci

Buildkite build #3217 is running...

Test

e2e/npm_link_package

Buildkite build #3217 is running...

Test

e2e/npm_link_package-esm

Buildkite build #3217 is running...

Test

e2e/npm_translate_lock

Buildkite build #3217 is running...

Test

e2e/npm_translate_lock_empty

Buildkite build #3217 is running...

Test

e2e/npm_translate_lock_multi

Buildkite build #3217 is running...

Test

e2e/npm_translate_lock_partial_clone

Buildkite build #3217 is running...

Test

e2e/npm_translate_lock_subdir_patch

Buildkite build #3217 is running...

Test

e2e/npm_translate_package_lock

Buildkite build #3217 is running...

Test

e2e/npm_translate_yarn_lock

Buildkite build #3217 is running...

Test

e2e/package_json_module

Buildkite build #3217 is running...

Test

e2e/pnpm_lockfiles

Buildkite build #3217 is running...

Test

e2e/pnpm_workspace

Buildkite build #3217 is running...

Test

e2e/pnpm_workspace_rerooted

Buildkite build #3217 is running...

Test

e2e/rules_foo

Buildkite build #3217 is running...

Test

e2e/vendored_node

Buildkite build #3217 is running...

Buildifier      Format

@jbedard jbedard force-pushed the 2.x-rm-yaml-parser branch from 01400a7 to 38cfbbf Compare April 19, 2024 05:28
gregmagolan
gregmagolan approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@gregmagolan gregmagolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@jbedard jbedard merged commit 7e8b080 into aspect-build:2.x Apr 19, 2024
94 checks passed
@jbedard jbedard deleted the 2.x-rm-yaml-parser branch April 19, 2024 21:09
jbedard added a commit that referenced this pull request Apr 19, 2024
@jbedard
refactor: remove npm_translate_lock(use_starlark_yaml_parser) (#1658)
22b99e9
gregmagolan pushed a commit that referenced this pull request Apr 20, 2024
@jbedard @gregmagolan
refactor: remove npm_translate_lock(use_starlark_yaml_parser) (#1658)
87eba91
gregmagolan pushed a commit that referenced this pull request Apr 21, 2024
@jbedard @gregmagolan
refactor: remove npm_translate_lock(use_starlark_yaml_parser) (#1658)
58704c5
gregmagolan pushed a commit that referenced this pull request Apr 21, 2024
@jbedard @gregmagolan
refactor: remove npm_translate_lock(use_starlark_yaml_parser) (#1658)
6908764
gregmagolan pushed a commit that referenced this pull request Apr 22, 2024
@jbedard @gregmagolan
refactor: remove npm_translate_lock(use_starlark_yaml_parser) (#1658)
39ad019
gregmagolan pushed a commit that referenced this pull request Apr 23, 2024
@jbedard @gregmagolan
refactor: remove npm_translate_lock(use_starlark_yaml_parser) (#1658)
1fabed8
gregmagolan pushed a commit that referenced this pull request Apr 24, 2024
@jbedard @gregmagolan
refactor: remove npm_translate_lock(use_starlark_yaml_parser) (#1658)
2bb8d34
gregmagolan pushed a commit that referenced this pull request Apr 26, 2024
@jbedard @gregmagolan
refactor: remove npm_translate_lock(use_starlark_yaml_parser) (#1658)
5a0b0fc
gregmagolan pushed a commit that referenced this pull request Apr 28, 2024
@jbedard @gregmagolan
refactor: remove npm_translate_lock(use_starlark_yaml_parser) (#1658)
4fb5edf
gregmagolan pushed a commit that referenced this pull request Apr 28, 2024
@jbedard @gregmagolan
refactor: remove npm_translate_lock(use_starlark_yaml_parser) (#1658)
018fd60
gregmagolan pushed a commit that referenced this pull request Apr 29, 2024
@jbedard @gregmagolan
refactor: remove npm_translate_lock(use_starlark_yaml_parser) (#1658)
302df7b
@gregmagolan gregmagolan mentioned this pull request Apr 29, 2024
Closed
21 tasks
gregmagolan pushed a commit that referenced this pull request May 6, 2024
@jbedard @gregmagolan
refactor: remove npm_translate_lock(use_starlark_yaml_parser) (#1658)
3bc48c0
jbedard added a commit that referenced this pull request May 6, 2024
@jbedard
refactor: remove npm_translate_lock(use_starlark_yaml_parser) (#1658)
b2c5593
gregmagolan pushed a commit that referenced this pull request May 7, 2024
@jbedard @gregmagolan
refactor: remove npm_translate_lock(use_starlark_yaml_parser) (#1658)
b7cf7e2
gregmagolan pushed a commit that referenced this pull request May 7, 2024
@jbedard @gregmagolan
refactor: remove npm_translate_lock(use_starlark_yaml_parser) (#1658)
2efc837
gregmagolan pushed a commit that referenced this pull request May 7, 2024
@jbedard @gregmagolan
refactor: remove npm_translate_lock(use_starlark_yaml_parser) (#1658)
6a910fa
gregmagolan pushed a commit that referenced this pull request May 7, 2024
@jbedard @gregmagolan
refactor: remove npm_translate_lock(use_starlark_yaml_parser) (#1658)
ffdd9d8
gregmagolan pushed a commit that referenced this pull request May 7, 2024
@jbedard @gregmagolan
refactor: remove npm_translate_lock(use_starlark_yaml_parser) (#1658)
2586397
jbedard added a commit that referenced this pull request May 8, 2024
@jbedard
refactor: remove npm_translate_lock(use_starlark_yaml_parser) (#1658)
5a335af
gregmagolan pushed a commit that referenced this pull request May 10, 2024
@jbedard @gregmagolan
refactor: remove npm_translate_lock(use_starlark_yaml_parser) (#1658)
fc2da67
gregmagolan pushed a commit that referenced this pull request May 10, 2024
@jbedard @gregmagolan
refactor: remove npm_translate_lock(use_starlark_yaml_parser) (#1658)
a8ea698
@gregmagolan gregmagolan mentioned this pull request May 10, 2024
Merged
gregmagolan pushed a commit that referenced this pull request May 13, 2024
@jbedard @gregmagolan
refactor: remove npm_translate_lock(use_starlark_yaml_parser) (#1658)
45ab853
jbedard added a commit to jbedard/rules_js that referenced this pull request May 14, 2024
@jbedard
refactor: remove npm_translate_lock(use_starlark_yaml_parser) (aspect…
fd25ded 
…-build#1658)
jbedard added a commit that referenced this pull request May 14, 2024
@jbedard
refactor: remove npm_translate_lock(use_starlark_yaml_parser) (#1658)
181e168
jbedard added a commit to jbedard/rules_js that referenced this pull request May 16, 2024
@jbedard
refactor: remove npm_translate_lock(use_starlark_yaml_parser) (aspect…
3eb51df 
…-build#1658)
gregmagolan pushed a commit that referenced this pull request May 20, 2024
@jbedard @gregmagolan
refactor: remove npm_translate_lock(use_starlark_yaml_parser) (#1658)
967ed88
gregmagolan pushed a commit that referenced this pull request May 20, 2024
@jbedard @gregmagolan
refactor: remove npm_translate_lock(use_starlark_yaml_parser) (#1658)
1fccc40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregmagolan gregmagolan gregmagolan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbedard @gregmagolan