Skip to content

Commit

Permalink
refactor: remove npm_translate_lock(use_starlark_yaml_parser)
Browse files Browse the repository at this point in the history
  • Loading branch information
@jbedard
jbedard committed Apr 19, 2024
1 parent 1ae9416 commit 01400a7
Show file tree
Hide file tree
Showing 16 changed files with 132 additions and 1,433 deletions.
3 changes: 1 addition & 2 deletions docs/npm_translate_lock.md
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion e2e/npm_translate_lock/WORKSPACE
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ npm_translate_lock(
npmrc = "//:.npmrc",
pnpm_lock = "//:pnpm-lock.yaml",
update_pnpm_lock = True,
use_starlark_yaml_parser = True, # test coverage for this flag
verify_node_modules_ignored = "//:.bazelignore",
)

Expand Down
1 change: 0 additions & 1 deletion e2e/webpack_devserver/MODULE.bazel
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ npm.npm_translate_lock(
name = "npm",
npmrc = "//:.npmrc",
pnpm_lock = "//:pnpm-lock.yaml",
use_starlark_yaml_parser = True, # test coverage for this flag
verify_node_modules_ignored = "//:.bazelignore",
)
use_repo(npm, "npm")
Expand Down
32 changes: 16 additions & 16 deletions js/private/test/image/custom_owner_app.listing
View file
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
drwxr-xr-x 100/0 0 1970-01-01 00:00 app
drwxr-xr-x 100/0 0 1970-01-01 00:00 app/js
drwxr-xr-x 100/0 0 1970-01-01 00:00 app/js/private
drwxr-xr-x 100/0 0 1970-01-01 00:00 app/js/private/test
drwxr-xr-x 100/0 0 1970-01-01 00:00 app/js/private/test/image
-r-xr-xr-x 100/0 131 1970-01-01 00:00 app/js/private/test/image/bin
drwxr-xr-x 100/0 0 1970-01-01 00:00 app/js/private/test/image/bin.runfiles
drwxr-xr-x 100/0 0 1970-01-01 00:00 app/js/private/test/image/bin.runfiles/aspect_rules_js
drwxr-xr-x 100/0 0 1970-01-01 00:00 app/js/private/test/image/bin.runfiles/aspect_rules_js/js
drwxr-xr-x 100/0 0 1970-01-01 00:00 app/js/private/test/image/bin.runfiles/aspect_rules_js/js/private
drwxr-xr-x 100/0 0 1970-01-01 00:00 app/js/private/test/image/bin.runfiles/aspect_rules_js/js/private/test
drwxr-xr-x 100/0 0 1970-01-01 00:00 app/js/private/test/image/bin.runfiles/aspect_rules_js/js/private/test/image
-r-xr-xr-x 100/0 23948 1970-01-01 00:00 app/js/private/test/image/bin.runfiles/aspect_rules_js/js/private/test/image/bin
drwxr-xr-x 100/0 0 1970-01-01 00:00 app/js/private/test/image/bin.runfiles/aspect_rules_js/js/private/test/image/bin_node_bin
-r-xr-xr-x 100/0 133 1970-01-01 00:00 app/js/private/test/image/bin.runfiles/aspect_rules_js/js/private/test/image/bin_node_bin/node
-r-xr-xr-x 100/0 20 1970-01-01 00:00 app/js/private/test/image/bin.runfiles/aspect_rules_js/js/private/test/image/main.js
drwxr-xr-x 0 100 0 0 Jan 1 1970 app
drwxr-xr-x 0 100 0 0 Jan 1 1970 app/js
drwxr-xr-x 0 100 0 0 Jan 1 1970 app/js/private
drwxr-xr-x 0 100 0 0 Jan 1 1970 app/js/private/test
drwxr-xr-x 0 100 0 0 Jan 1 1970 app/js/private/test/image
-r-xr-xr-x 0 100 0 131 Jan 1 1970 app/js/private/test/image/bin
drwxr-xr-x 0 100 0 0 Jan 1 1970 app/js/private/test/image/bin.runfiles
drwxr-xr-x 0 100 0 0 Jan 1 1970 app/js/private/test/image/bin.runfiles/aspect_rules_js
drwxr-xr-x 0 100 0 0 Jan 1 1970 app/js/private/test/image/bin.runfiles/aspect_rules_js/js
drwxr-xr-x 0 100 0 0 Jan 1 1970 app/js/private/test/image/bin.runfiles/aspect_rules_js/js/private
drwxr-xr-x 0 100 0 0 Jan 1 1970 app/js/private/test/image/bin.runfiles/aspect_rules_js/js/private/test
drwxr-xr-x 0 100 0 0 Jan 1 1970 app/js/private/test/image/bin.runfiles/aspect_rules_js/js/private/test/image
-r-xr-xr-x 0 100 0 23948 Jan 1 1970 app/js/private/test/image/bin.runfiles/aspect_rules_js/js/private/test/image/bin
drwxr-xr-x 0 100 0 0 Jan 1 1970 app/js/private/test/image/bin.runfiles/aspect_rules_js/js/private/test/image/bin_node_bin
-r-xr-xr-x 0 100 0 133 Jan 1 1970 app/js/private/test/image/bin.runfiles/aspect_rules_js/js/private/test/image/bin_node_bin/node
-r-xr-xr-x 0 100 0 20 Jan 1 1970 app/js/private/test/image/bin.runfiles/aspect_rules_js/js/private/test/image/main.js
76 changes: 38 additions & 38 deletions js/private/test/image/custom_owner_node_modules.listing
View file
Original file line number Diff line number Diff line change
@@ -1,38 +1,38 @@
drwxr-xr-x 100/0 0 1970-01-01 00:00 app
drwxr-xr-x 100/0 0 1970-01-01 00:00 app/js
drwxr-xr-x 100/0 0 1970-01-01 00:00 app/js/private
drwxr-xr-x 100/0 0 1970-01-01 00:00 app/js/private/test
drwxr-xr-x 100/0 0 1970-01-01 00:00 app/js/private/test/image
drwxr-xr-x 100/0 0 1970-01-01 00:00 app/js/private/test/image/bin.runfiles
drwxr-xr-x 100/0 0 1970-01-01 00:00 app/js/private/test/image/bin.runfiles/aspect_rules_js
drwxr-xr-x 100/0 0 1970-01-01 00:00 app/js/private/test/image/bin.runfiles/aspect_rules_js/js
drwxr-xr-x 100/0 0 1970-01-01 00:00 app/js/private/test/image/bin.runfiles/aspect_rules_js/js/private
drwxr-xr-x 100/0 0 1970-01-01 00:00 app/js/private/test/image/bin.runfiles/aspect_rules_js/js/private/node-patches
-r-xr-xr-x 100/0 32555 1970-01-01 00:00 app/js/private/test/image/bin.runfiles/aspect_rules_js/js/private/node-patches/fs.js
-r-xr-xr-x 100/0 1698 1970-01-01 00:00 app/js/private/test/image/bin.runfiles/aspect_rules_js/js/private/node-patches/register.js
drwxr-xr-x 100/0 0 1970-01-01 00:00 app/js/private/test/image/bin.runfiles/aspect_rules_js/js/private/test
drwxr-xr-x 100/0 0 1970-01-01 00:00 app/js/private/test/image/bin.runfiles/aspect_rules_js/js/private/test/image
drwxr-xr-x 100/0 0 1970-01-01 00:00 app/js/private/test/image/bin.runfiles/aspect_rules_js/js/private/test/image/node_modules
lrwxrwxr-x 100/0 0 1970-01-01 00:00 app/js/private/test/image/bin.runfiles/aspect_rules_js/js/private/test/image/node_modules/acorn -> ../../../../../node_modules/.aspect_rules_js/[email protected]/node_modules/acorn
drwxr-xr-x 100/0 0 1970-01-01 00:00 app/js/private/test/image/bin.runfiles/aspect_rules_js/node_modules
drwxr-xr-x 100/0 0 1970-01-01 00:00 app/js/private/test/image/bin.runfiles/aspect_rules_js/node_modules/.aspect_rules_js
drwxr-xr-x 100/0 0 1970-01-01 00:00 app/js/private/test/image/bin.runfiles/aspect_rules_js/node_modules/.aspect_rules_js/[email protected]
drwxr-xr-x 100/0 0 1970-01-01 00:00 app/js/private/test/image/bin.runfiles/aspect_rules_js/node_modules/.aspect_rules_js/[email protected]/node_modules
drwxr-xr-x 100/0 0 1970-01-01 00:00 app/js/private/test/image/bin.runfiles/aspect_rules_js/node_modules/.aspect_rules_js/[email protected]/node_modules/acorn
-r-xr-xr-x 100/0 19838 1970-01-01 00:00 app/js/private/test/image/bin.runfiles/aspect_rules_js/node_modules/.aspect_rules_js/[email protected]/node_modules/acorn/CHANGELOG.md
-r-xr-xr-x 100/0 1099 1970-01-01 00:00 app/js/private/test/image/bin.runfiles/aspect_rules_js/node_modules/.aspect_rules_js/[email protected]/node_modules/acorn/LICENSE
-r-xr-xr-x 100/0 10364 1970-01-01 00:00 app/js/private/test/image/bin.runfiles/aspect_rules_js/node_modules/.aspect_rules_js/[email protected]/node_modules/acorn/README.md
drwxr-xr-x 100/0 0 1970-01-01 00:00 app/js/private/test/image/bin.runfiles/aspect_rules_js/node_modules/.aspect_rules_js/[email protected]/node_modules/acorn/bin
-r-xr-xr-x 100/0 60 1970-01-01 00:00 app/js/private/test/image/bin.runfiles/aspect_rules_js/node_modules/.aspect_rules_js/[email protected]/node_modules/acorn/bin/acorn
drwxr-xr-x 100/0 0 1970-01-01 00:00 app/js/private/test/image/bin.runfiles/aspect_rules_js/node_modules/.aspect_rules_js/[email protected]/node_modules/acorn/dist
-r-xr-xr-x 100/0 6212 1970-01-01 00:00 app/js/private/test/image/bin.runfiles/aspect_rules_js/node_modules/.aspect_rules_js/[email protected]/node_modules/acorn/dist/acorn.d.ts
-r-xr-xr-x 100/0 218042 1970-01-01 00:00 app/js/private/test/image/bin.runfiles/aspect_rules_js/node_modules/.aspect_rules_js/[email protected]/node_modules/acorn/dist/acorn.js
-r-xr-xr-x 100/0 207423 1970-01-01 00:00 app/js/private/test/image/bin.runfiles/aspect_rules_js/node_modules/.aspect_rules_js/[email protected]/node_modules/acorn/dist/acorn.mjs
-r-xr-xr-x 100/0 49 1970-01-01 00:00 app/js/private/test/image/bin.runfiles/aspect_rules_js/node_modules/.aspect_rules_js/[email protected]/node_modules/acorn/dist/acorn.mjs.d.ts
-r-xr-xr-x 100/0 3261 1970-01-01 00:00 app/js/private/test/image/bin.runfiles/aspect_rules_js/node_modules/.aspect_rules_js/[email protected]/node_modules/acorn/dist/bin.js
-r-xr-xr-x 100/0 1058 1970-01-01 00:00 app/js/private/test/image/bin.runfiles/aspect_rules_js/node_modules/.aspect_rules_js/[email protected]/node_modules/acorn/package.json
drwxr-xr-x 100/0 0 1970-01-01 00:00 app/js/private/test/image/bin.runfiles/nodejs_linux_amd64
drwxr-xr-x 100/0 0 1970-01-01 00:00 app/js/private/test/image/bin.runfiles/nodejs_linux_amd64/bin
drwxr-xr-x 100/0 0 1970-01-01 00:00 app/js/private/test/image/bin.runfiles/nodejs_linux_amd64/bin/nodejs
drwxr-xr-x 100/0 0 1970-01-01 00:00 app/js/private/test/image/bin.runfiles/nodejs_linux_amd64/bin/nodejs/bin
-r-xr-xr-x 100/0 80316256 1970-01-01 00:00 app/js/private/test/image/bin.runfiles/nodejs_linux_amd64/bin/nodejs/bin/node
drwxr-xr-x 0 100 0 0 Jan 1 1970 app
drwxr-xr-x 0 100 0 0 Jan 1 1970 app/js
drwxr-xr-x 0 100 0 0 Jan 1 1970 app/js/private
drwxr-xr-x 0 100 0 0 Jan 1 1970 app/js/private/test
drwxr-xr-x 0 100 0 0 Jan 1 1970 app/js/private/test/image
drwxr-xr-x 0 100 0 0 Jan 1 1970 app/js/private/test/image/bin.runfiles
drwxr-xr-x 0 100 0 0 Jan 1 1970 app/js/private/test/image/bin.runfiles/aspect_rules_js
drwxr-xr-x 0 100 0 0 Jan 1 1970 app/js/private/test/image/bin.runfiles/aspect_rules_js/js
drwxr-xr-x 0 100 0 0 Jan 1 1970 app/js/private/test/image/bin.runfiles/aspect_rules_js/js/private
drwxr-xr-x 0 100 0 0 Jan 1 1970 app/js/private/test/image/bin.runfiles/aspect_rules_js/js/private/node-patches
-r-xr-xr-x 0 100 0 32555 Jan 1 1970 app/js/private/test/image/bin.runfiles/aspect_rules_js/js/private/node-patches/fs.js
-r-xr-xr-x 0 100 0 1698 Jan 1 1970 app/js/private/test/image/bin.runfiles/aspect_rules_js/js/private/node-patches/register.js
drwxr-xr-x 0 100 0 0 Jan 1 1970 app/js/private/test/image/bin.runfiles/aspect_rules_js/js/private/test
drwxr-xr-x 0 100 0 0 Jan 1 1970 app/js/private/test/image/bin.runfiles/aspect_rules_js/js/private/test/image
drwxr-xr-x 0 100 0 0 Jan 1 1970 app/js/private/test/image/bin.runfiles/aspect_rules_js/js/private/test/image/node_modules
lrwxrwxr-x 0 100 0 0 Jan 1 1970 app/js/private/test/image/bin.runfiles/aspect_rules_js/js/private/test/image/node_modules/acorn -> ../../../../../node_modules/.aspect_rules_js/[email protected]/node_modules/acorn
drwxr-xr-x 0 100 0 0 Jan 1 1970 app/js/private/test/image/bin.runfiles/aspect_rules_js/node_modules
drwxr-xr-x 0 100 0 0 Jan 1 1970 app/js/private/test/image/bin.runfiles/aspect_rules_js/node_modules/.aspect_rules_js
drwxr-xr-x 0 100 0 0 Jan 1 1970 app/js/private/test/image/bin.runfiles/aspect_rules_js/node_modules/.aspect_rules_js/[email protected]
drwxr-xr-x 0 100 0 0 Jan 1 1970 app/js/private/test/image/bin.runfiles/aspect_rules_js/node_modules/.aspect_rules_js/[email protected]/node_modules
drwxr-xr-x 0 100 0 0 Jan 1 1970 app/js/private/test/image/bin.runfiles/aspect_rules_js/node_modules/.aspect_rules_js/[email protected]/node_modules/acorn
-r-xr-xr-x 0 100 0 19838 Jan 1 1970 app/js/private/test/image/bin.runfiles/aspect_rules_js/node_modules/.aspect_rules_js/[email protected]/node_modules/acorn/CHANGELOG.md
-r-xr-xr-x 0 100 0 1099 Jan 1 1970 app/js/private/test/image/bin.runfiles/aspect_rules_js/node_modules/.aspect_rules_js/[email protected]/node_modules/acorn/LICENSE
-r-xr-xr-x 0 100 0 10364 Jan 1 1970 app/js/private/test/image/bin.runfiles/aspect_rules_js/node_modules/.aspect_rules_js/[email protected]/node_modules/acorn/README.md
drwxr-xr-x 0 100 0 0 Jan 1 1970 app/js/private/test/image/bin.runfiles/aspect_rules_js/node_modules/.aspect_rules_js/[email protected]/node_modules/acorn/bin
-r-xr-xr-x 0 100 0 60 Jan 1 1970 app/js/private/test/image/bin.runfiles/aspect_rules_js/node_modules/.aspect_rules_js/[email protected]/node_modules/acorn/bin/acorn
drwxr-xr-x 0 100 0 0 Jan 1 1970 app/js/private/test/image/bin.runfiles/aspect_rules_js/node_modules/.aspect_rules_js/[email protected]/node_modules/acorn/dist
-r-xr-xr-x 0 100 0 6212 Jan 1 1970 app/js/private/test/image/bin.runfiles/aspect_rules_js/node_modules/.aspect_rules_js/[email protected]/node_modules/acorn/dist/acorn.d.ts
-r-xr-xr-x 0 100 0 218042 Jan 1 1970 app/js/private/test/image/bin.runfiles/aspect_rules_js/node_modules/.aspect_rules_js/[email protected]/node_modules/acorn/dist/acorn.js
-r-xr-xr-x 0 100 0 207423 Jan 1 1970 app/js/private/test/image/bin.runfiles/aspect_rules_js/node_modules/.aspect_rules_js/[email protected]/node_modules/acorn/dist/acorn.mjs
-r-xr-xr-x 0 100 0 49 Jan 1 1970 app/js/private/test/image/bin.runfiles/aspect_rules_js/node_modules/.aspect_rules_js/[email protected]/node_modules/acorn/dist/acorn.mjs.d.ts
-r-xr-xr-x 0 100 0 3261 Jan 1 1970 app/js/private/test/image/bin.runfiles/aspect_rules_js/node_modules/.aspect_rules_js/[email protected]/node_modules/acorn/dist/bin.js
-r-xr-xr-x 0 100 0 1058 Jan 1 1970 app/js/private/test/image/bin.runfiles/aspect_rules_js/node_modules/.aspect_rules_js/[email protected]/node_modules/acorn/package.json
drwxr-xr-x 0 100 0 0 Jan 1 1970 app/js/private/test/image/bin.runfiles/nodejs_linux_amd64
drwxr-xr-x 0 100 0 0 Jan 1 1970 app/js/private/test/image/bin.runfiles/nodejs_linux_amd64/bin
drwxr-xr-x 0 100 0 0 Jan 1 1970 app/js/private/test/image/bin.runfiles/nodejs_linux_amd64/bin/nodejs
drwxr-xr-x 0 100 0 0 Jan 1 1970 app/js/private/test/image/bin.runfiles/nodejs_linux_amd64/bin/nodejs/bin
-r-xr-xr-x 0 100 0 80316256 Jan 1 1970 app/js/private/test/image/bin.runfiles/nodejs_linux_amd64/bin/nodejs/bin/node
Loading

0 comments on commit 01400a7

Please sign in to comment.