Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: refactor case10 and case10a tests so they don't have duplicate outputs #276

Merged
merged 1 commit into from
Apr 28, 2024
Merged

fix: refactor case10 and case10a tests so they don't have duplicate outputs #276

merged 1 commit into from
Apr 28, 2024

Conversation

gregmagolan
Copy link
Member

@gregmagolan gregmagolan commented Apr 28, 2024 •
edited
Loading

Pre-factor from #269.

Fixes build issue:

(17:42:17) ERROR: One of the output paths 'bazel-out/k8-fastbuild/bin/jest/tests/case10' (belonging to //jest/tests:case10) and 'bazel-out/k8-fastbuild/bin/jest/tests/case10/case10.test.js' (belonging to //jest/tests:case10_update_snapshots) is a prefix of the other. These actions cannot be simultaneously present; please rename one of the output files or build just one of them
(17:42:17) ERROR: One of the output paths 'bazel-out/k8-fastbuild/bin/jest/tests/case10' (belonging to //jest/tests:case10) and 'bazel-out/k8-fastbuild/bin/jest/tests/case10/__snapshots__/case10.test.js.snap' (belonging to //jest/tests:case10a) is a prefix of the other. These actions cannot be simultaneously present; please rename one of the output files or build just one of them

@aspect-workflows Aspect Workflows
Copy link

aspect-workflows bot commented Apr 28, 2024 •
edited
Loading

Test

All tests were cache hits

55 tests (100.0%) were fully cached saving 2m 10s.

Buildifier      Format      Gazelle

@gregmagolan gregmagolan force-pushed the refactor_case10_test branch 3 times, most recently from 2adfc9b to 50012f8 Compare April 28, 2024 18:14
@gregmagolan gregmagolan force-pushed the refactor_case10_test branch from 50012f8 to 2908f4e Compare April 28, 2024 18:17
@gregmagolan gregmagolan force-pushed the refactor_case10_test branch from 2908f4e to 3e643fe Compare April 28, 2024 18:24
alexeagle
alexeagle approved these changes Apr 28, 2024
View reviewed changes
docs/BUILD.bazel Show resolved Hide resolved
@gregmagolan gregmagolan merged commit 9b6a225 into main Apr 28, 2024
21 checks passed
@gregmagolan gregmagolan deleted the refactor_case10_test branch April 28, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeagle alexeagle alexeagle approved these changes

@jbedard jbedard Awaiting requested review from jbedard

@kormide kormide Awaiting requested review from kormide

@CaerusKaru CaerusKaru Awaiting requested review from CaerusKaru

@JesseTatasciore JesseTatasciore Awaiting requested review from JesseTatasciore

@mrmeku mrmeku Awaiting requested review from mrmeku

@mattem mattem Awaiting requested review from mattem

@thesayyn thesayyn Awaiting requested review from thesayyn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gregmagolan @alexeagle