Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to rules_js 2.0 #269

Merged
merged 1 commit into from
May 22, 2024
Merged

feat: upgrade to rules_js 2.0 #269

merged 1 commit into from
May 22, 2024

Conversation

gregmagolan
Copy link
Member

@gregmagolan gregmagolan commented Apr 20, 2024


Type of change

  • New feature or functionality (change which adds functionality)

For changes visible to end-users

  • Breaking change (this change will force users to change their own code or config)
  • Suggested release notes are provided below:

Test plan

  • Covered by existing test cases

@gregmagolan gregmagolan mentioned this pull request Apr 20, 2024
21 tasks
Copy link

aspect-workflows bot commented Apr 20, 2024

Test

56 test targets passed

Targets
//:case3 [k8-fastbuild]                                                3s
//example/(simple_group):cjs_config_test [k8-fastbuild]                3s
//example/(simple_group):gen_config_test [k8-fastbuild]                3s
//example/(simple_group):js_config_test [k8-fastbuild]                 3s
//example/(simple_group):json_config_test [k8-fastbuild]               6s
//example/(simple_group):mjs_config_test [k8-fastbuild]                2s
//example/(simple_group):other_target_config_test [k8-fastbuild]       3s
//example/(simple_group):target_config_test [k8-fastbuild]             5s
//example/(simple_group):test [k8-fastbuild]                           5s
//example/(simple_group):test_user_data [k8-fastbuild]                 3s
//example/custom_reporters:case1_test [k8-fastbuild]                   2s
//example/custom_reporters:case2_test [k8-fastbuild]                   5s
//example/custom_sequencer:case1_test [k8-fastbuild]                   9s
//example/custom_sequencer:case2_test [k8-fastbuild]                   6s
//example/custom_snapshot_resolver:test [k8-fastbuild]                 3s
//example/custom_snapshot_resolver_files:test [k8-fastbuild]           4s
//example/esm:test [k8-fastbuild]                                      2s
//example/esm_transform:test [k8-fastbuild]                            3s
//example/esm_type_module:test [k8-fastbuild]                          3s
//example/multiple_snapshots:test [k8-fastbuild]                       4s
//example/multiple_snapshots:update_snapshots_build [k8-fastbuild]     219ms
//example/sharding:test [k8-fastbuild]                                 5s
//example/simple:cjs_config_test [k8-fastbuild]                        2s
//example/simple:gen_config_test [k8-fastbuild]                        2s
//example/simple:js_config_test [k8-fastbuild]                         2s
//example/simple:json_config_test [k8-fastbuild]                       2s
//example/simple:mjs_config_test [k8-fastbuild]                        2s
//example/simple:other_target_config_test [k8-fastbuild]               3s
//example/simple:target_config_test [k8-fastbuild]                     3s
//example/simple:test [k8-fastbuild]                                   3s
//example/simple:test_user_data [k8-fastbuild]                         2s
//example/snapshots:test [k8-fastbuild]                                4s
//example/snapshots:update_snapshots_build [k8-fastbuild]              97ms
//example/snapshots_files:test [k8-fastbuild]                          4s
//jest/tests/case10:cupdate_snapshots_build [k8-fastbuild]             138ms
//jest/tests/case10:test [k8-fastbuild]                                2s
//jest/tests/case10a:test [k8-fastbuild]                               2s
//jest/tests/case10a:update_snapshots_build [k8-fastbuild]             77ms
//jest/tests/env_inherit:test [k8-fastbuild]                           2s
//jest/tests/fixed_args:fixed_args_test [k8-fastbuild]                 951ms
//jest/tests/fixed_args:test [k8-fastbuild]                            5s
//jest/tests/package_json_module:test [k8-fastbuild]                   4s
//jest/tests/package_json_module:update_snapshots_build [k8-fastbuild] 236ms
//jest/tests:case1 [k8-fastbuild]                                      2s
//jest/tests:case11a [k8-fastbuild]                                    2s
//jest/tests:case11b [k8-fastbuild]                                    3s
//jest/tests:case12 [k8-fastbuild]                                     3s
//jest/tests:case13 [k8-fastbuild]                                     2s
//jest/tests:case14 [k8-fastbuild]                                     2s
//jest/tests:case2a [k8-fastbuild]                                     2s
//jest/tests:case2b [k8-fastbuild]                                     2s
//jest/tests:case5 [k8-fastbuild]                                      2s
//jest/tests:case6 [k8-fastbuild]                                      2s
//jest/tests:case7 [k8-fastbuild]                                      2s
//jest/tests:case8 [k8-fastbuild]                                      2s
//jest/tests:case9 [k8-fastbuild]                                      2s

Total test execution time was 2m 42s. 9 tests (13.8%) were fully cached saving 2s.


Buildifier      Format      Gazelle

@gregmagolan gregmagolan force-pushed the rules_js_2 branch 15 times, most recently from b75ceb9 to c835550 Compare April 25, 2024 23:43
@gregmagolan gregmagolan force-pushed the rules_js_2 branch 8 times, most recently from 5f780dc to 77e6473 Compare April 28, 2024 18:10
@gregmagolan gregmagolan force-pushed the rules_js_2 branch 4 times, most recently from 279acfb to 54fd3f0 Compare April 28, 2024 19:25
@gregmagolan gregmagolan force-pushed the rules_js_2 branch 3 times, most recently from ce34c11 to 5840ed5 Compare April 29, 2024 01:14
@gregmagolan gregmagolan marked this pull request as ready for review April 29, 2024 01:16
@gregmagolan gregmagolan requested a review from jbedard April 29, 2024 01:16
bazel_dep(name = "platforms", version = "0.0.4", dev_dependency = True)
bazel_dep(name = "platforms", version = "0.0.9", dev_dependency = True)

archive_override(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove before landing (once rules_swc has a release to use)

e2e/swc/WORKSPACE.bazel Outdated Show resolved Hide resolved
@gregmagolan gregmagolan force-pushed the rules_js_2 branch 11 times, most recently from 57b30f2 to c9da3e1 Compare May 15, 2024 04:25
@gregmagolan gregmagolan force-pushed the rules_js_2 branch 2 times, most recently from 673dd48 to b2f3470 Compare May 21, 2024 15:29
@gregmagolan gregmagolan merged commit 4857c26 into main May 22, 2024
21 checks passed
@gregmagolan gregmagolan deleted the rules_js_2 branch May 22, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants